Updates to Ingress #12465
Merged
Updates to Ingress #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move Ingress controllers content to own page * Link to Set up Ingress on Minikube with the NGINX Controller task * Minor edits
k8s-ci-robot
added
cncf-cla: yes
|
Hi @cody-clark, is there a preview for this PR? Or a way to force a preview to generate? Thanks! |
|
Hi @kbhawkey, thanks! I didn't realize that Netlify didn't do it's thing. I'll try to figure that out! |
|
🎉 Awesome @cody-clark ! This looks good to me 😄 |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 5f08869 https://deploy-preview-12465--kubernetes-io-master-staging.netlify.com |
kwiesmueller
pushed a commit
to kwiesmueller/website
that referenced
this pull request
Feb 28, 2019
* Create ingress-minikube.md * Update ingress.md * Move Ingress controllers content to own page * Link to Set up Ingress on Minikube with the NGINX Controller task * Minor edits * Create ingress-controllers.md * Update ingress-controllers.md
krmayankk
pushed a commit
to krmayankk/kubernetes.github.io
that referenced
this pull request
Mar 11, 2019
* Create ingress-minikube.md * Update ingress.md * Move Ingress controllers content to own page * Link to Set up Ingress on Minikube with the NGINX Controller task * Minor edits * Create ingress-controllers.md * Update ingress-controllers.md
yagonobre
pushed a commit
to yagonobre/website
that referenced
this pull request
Mar 14, 2019
* Create ingress-minikube.md * Update ingress.md * Move Ingress controllers content to own page * Link to Set up Ingress on Minikube with the NGINX Controller task * Minor edits * Create ingress-controllers.md * Update ingress-controllers.md
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Ingress Minikube task
Cleared out info from Ingress Concept page and minor edits
Created a new page for Ingress Controllers
Partial fixes to #4478