Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate concepts/containers/container-environment-variables in Korean #12382

Merged

Conversation

seokho-son
Copy link
Member

Fixes #12381.

@k8s-ci-robot k8s-ci-robot added language/ko Issues or PRs related to Korean language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2019
Copy link
Contributor

@claudiajkang claudiajkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seokho-son

리뷰가 늦어져서 죄송합니다. 리뷰 내용 확인 부탁드립니다.

@claudiajkang
Copy link
Contributor

/assign

@seokho-son
Copy link
Member Author

@claudiajkang 리뷰 감사합니다. 코멘트 반영하여 다시 올렸습니다.. :)

@claudiajkang
Copy link
Contributor

@seokho-son 리뷰 완료했습니다~.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ClaudiaJKang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit a764f2f into kubernetes:dev-1.13-ko.5 Jan 28, 2019
claudiajkang added a commit that referenced this pull request Jan 29, 2019
* ko-trans: glossary/kube-scheduler.md (#12269)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (#12246)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (#12267)
* Update outdated in tutorials/kubernetes-basics/ for dev-1.13-ko.5 (#12272)
* ko/examples/application/deployment.yaml (#12293)
* ko-trans: add tutorials/hello-minikube.md #11532 (#12273)
* Translate concepts/containers/container-environment-variables in Korean (#12382)
* ko: Tutorial compoent rearrange (#12400)
* Translate content/ko/docs/concepts/architecture/master-node-communication in Korean #11963 (#12315)
* Translate concepts/workloads/pods/podpreset in Korean (#12308)
* Translate concepts/workloads/pods/init-containers in Korean (#12298)
* ko-trans: add setup/minikube.md #11531 (#12274)
* ko/docs/setup/cluster-large.md (#12370)

Co-authored-by: Seokho <[email protected]>
Co-authored-by: Kim Young Dae <[email protected]>
Co-authored-by: Claudia J.Kang <[email protected]>
Co-authored-by: Yoon <[email protected]>
Co-authored-by: Jmnote <[email protected]>
Co-authored-by: June Yi <[email protected]>
k8s-ci-robot pushed a commit that referenced this pull request Jan 29, 2019
* ko-trans: glossary/kube-scheduler.md (#12269)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (#12246)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (#12267)
* Update outdated in tutorials/kubernetes-basics/ for dev-1.13-ko.5 (#12272)
* ko/examples/application/deployment.yaml (#12293)
* ko-trans: add tutorials/hello-minikube.md #11532 (#12273)
* Translate concepts/containers/container-environment-variables in Korean (#12382)
* ko: Tutorial compoent rearrange (#12400)
* Translate content/ko/docs/concepts/architecture/master-node-communication in Korean #11963 (#12315)
* Translate concepts/workloads/pods/podpreset in Korean (#12308)
* Translate concepts/workloads/pods/init-containers in Korean (#12298)
* ko-trans: add setup/minikube.md #11531 (#12274)
* ko/docs/setup/cluster-large.md (#12370)

Co-authored-by: Seokho <[email protected]>
Co-authored-by: Kim Young Dae <[email protected]>
Co-authored-by: Claudia J.Kang <[email protected]>
Co-authored-by: Yoon <[email protected]>
Co-authored-by: Jmnote <[email protected]>
Co-authored-by: June Yi <[email protected]>
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
* ko-trans: glossary/kube-scheduler.md (kubernetes#12269)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (kubernetes#12246)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (kubernetes#12267)
* Update outdated in tutorials/kubernetes-basics/ for dev-1.13-ko.5 (kubernetes#12272)
* ko/examples/application/deployment.yaml (kubernetes#12293)
* ko-trans: add tutorials/hello-minikube.md kubernetes#11532 (kubernetes#12273)
* Translate concepts/containers/container-environment-variables in Korean (kubernetes#12382)
* ko: Tutorial compoent rearrange (kubernetes#12400)
* Translate content/ko/docs/concepts/architecture/master-node-communication in Korean kubernetes#11963 (kubernetes#12315)
* Translate concepts/workloads/pods/podpreset in Korean (kubernetes#12308)
* Translate concepts/workloads/pods/init-containers in Korean (kubernetes#12298)
* ko-trans: add setup/minikube.md kubernetes#11531 (kubernetes#12274)
* ko/docs/setup/cluster-large.md (kubernetes#12370)

Co-authored-by: Seokho <[email protected]>
Co-authored-by: Kim Young Dae <[email protected]>
Co-authored-by: Claudia J.Kang <[email protected]>
Co-authored-by: Yoon <[email protected]>
Co-authored-by: Jmnote <[email protected]>
Co-authored-by: June Yi <[email protected]>
gochist added a commit to gochist/website that referenced this pull request Feb 19, 2019
* ko-trans: glossary/kube-scheduler.md (kubernetes#12269)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (kubernetes#12246)
* ko-trans: Update outdated files partly in dev-1.13-ko.5 (kubernetes#12267)
* Update outdated in tutorials/kubernetes-basics/ for dev-1.13-ko.5 (kubernetes#12272)
* ko/examples/application/deployment.yaml (kubernetes#12293)
* ko-trans: add tutorials/hello-minikube.md kubernetes#11532 (kubernetes#12273)
* Translate concepts/containers/container-environment-variables in Korean (kubernetes#12382)
* ko: Tutorial compoent rearrange (kubernetes#12400)
* Translate content/ko/docs/concepts/architecture/master-node-communication in Korean kubernetes#11963 (kubernetes#12315)
* Translate concepts/workloads/pods/podpreset in Korean (kubernetes#12308)
* Translate concepts/workloads/pods/init-containers in Korean (kubernetes#12298)
* ko-trans: add setup/minikube.md kubernetes#11531 (kubernetes#12274)
* ko/docs/setup/cluster-large.md (kubernetes#12370)

Co-authored-by: Seokho <[email protected]>
Co-authored-by: Kim Young Dae <[email protected]>
Co-authored-by: Claudia J.Kang <[email protected]>
Co-authored-by: Yoon <[email protected]>
Co-authored-by: Jmnote <[email protected]>
Co-authored-by: June Yi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Issues or PRs related to Korean language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants