Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ReadMe #11967

Merged
merged 4 commits into from
Feb 18, 2019
Merged

Updated ReadMe #11967

merged 4 commits into from
Feb 18, 2019

Conversation

drlukeangel
Copy link
Contributor

@drlukeangel drlukeangel commented Dec 29, 2018

Added windows commands

Added windows commands
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language labels Dec 29, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 29, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 538afa9

https://deploy-preview-11967--kubernetes-io-master-staging.netlify.com

@@ -243,23 +243,30 @@ The preceding configuration file defines a new context named `dev-ramp-up`.

See whether you have an environment variable named `KUBECONFIG`. If so, save the
current value of your `KUBECONFIG` environment variable, so you can restore it later.
For example, on Linux:

For example:
Copy link
Contributor

@shavidissa shavidissa Jan 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a <br> tag here too :)


Windows PowerShell
```shell
$Env:KUBECONFIG_SAVED=(config-demo;config-demo-2)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why do you need the raw line break?
  • You could add two sub-headers, such as:

    Linux, using bash:

    some linux commands ...

    Windows Powershell:

    some windows commands ...
  • Is this environment variable KUBECONFIG_SAVED correct?

@Rajakavitha1
Copy link
Contributor

@drlukeangel could you please address the suggestions in the review comments.

@zparnold
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit c613b54 into kubernetes:master Feb 18, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
* Updated ReadMe

Added windows commands

* Update configure-access-multiple-clusters.md

* Update configure-access-multiple-clusters.md

* Update configure-access-multiple-clusters.md
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
* Updated ReadMe

Added windows commands

* Update configure-access-multiple-clusters.md

* Update configure-access-multiple-clusters.md

* Update configure-access-multiple-clusters.md
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
* Updated ReadMe

Added windows commands

* Update configure-access-multiple-clusters.md

* Update configure-access-multiple-clusters.md

* Update configure-access-multiple-clusters.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants