-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ReadMe #11967
Updated ReadMe #11967
Conversation
Added windows commands
Deploy preview for kubernetes-io-master-staging ready! Built with commit 538afa9 https://deploy-preview-11967--kubernetes-io-master-staging.netlify.com |
@@ -243,23 +243,30 @@ The preceding configuration file defines a new context named `dev-ramp-up`. | |||
|
|||
See whether you have an environment variable named `KUBECONFIG`. If so, save the | |||
current value of your `KUBECONFIG` environment variable, so you can restore it later. | |||
For example, on Linux: | |||
|
|||
For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a <br>
tag here too :)
|
||
Windows PowerShell | ||
```shell | ||
$Env:KUBECONFIG_SAVED=(config-demo;config-demo-2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why do you need the raw line break?
- You could add two sub-headers, such as:
Linux, using bash:
some linux commands ...
Windows Powershell:
some windows commands ...
- Is this environment variable KUBECONFIG_SAVED correct?
@drlukeangel could you please address the suggestions in the review comments. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zparnold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Updated ReadMe Added windows commands * Update configure-access-multiple-clusters.md * Update configure-access-multiple-clusters.md * Update configure-access-multiple-clusters.md
* Updated ReadMe Added windows commands * Update configure-access-multiple-clusters.md * Update configure-access-multiple-clusters.md * Update configure-access-multiple-clusters.md
* Updated ReadMe Added windows commands * Update configure-access-multiple-clusters.md * Update configure-access-multiple-clusters.md * Update configure-access-multiple-clusters.md
Added windows commands