-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add audit doc #1193
Add audit doc #1193
Conversation
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions. docs/admin/audit.md, line 12 [r1] (raw file):
If this is where we're introducing the context of Audit in Kubernetes, it would be a good place to give a one- or two-sentence description of what Audit does and why it exists. Something like "Kubernetes Auditing makes sure that..." or "Kubernetes Audit provides..." docs/admin/audit.md, line 50 [r1] (raw file):
"If an audit log file already exists, Kubernetes appends new audit logs to that file. Otherwise, Kubernetes creates an audit log file at the location you specified in docs/admin/audit.md, line 54 [r1] (raw file):
Kubernetes may delete old log files when creating a new log file; you can configure how many files are retained and how old they can be by specifying the Comments from Reviewable |
8ff250e
to
2dd6e8a
Compare
Comments addressed, ptal. |
Review status: 0 of 2 files reviewed at latest revision, 3 unresolved discussions. Comments from Reviewable |
Looks good, but there are some merge conflicts. I can't merge until they're resolved. @soltysh , would you mind taking a look? |
2dd6e8a
to
7809151
Compare
@devin-donnelly rebased |
Thanks. Merging. |
* add linkerd uses iptables blog Signed-off-by: Christian Mejlak <[email protected]>
* [es] Localize cloud-native-tech.md * Revert change from resolving conflicts Signed-off-by: Rodolfo Martínez Vega <[email protected]>
* [es] Localize cloud-native-tech.md * Revert change from resolving conflicts Signed-off-by: Rodolfo Martínez Vega <[email protected]>
* [es] Localize cloud-native-tech.md * Revert change from resolving conflicts Signed-off-by: Rodolfo Martínez Vega <[email protected]>
This is copy of #1168 which already have tech approval (so I'm applying the label based on that) , I'm recreating it so it's part of 1.4.
@devin-donnelly ptal
@janetkuo @sttts fyi
This change is