Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cni-ipvlan-vpc-k8s #11929

Merged
merged 2 commits into from
Jan 3, 2019
Merged

add cni-ipvlan-vpc-k8s #11929

merged 2 commits into from
Jan 3, 2019

Conversation

bpownow
Copy link
Contributor

@bpownow bpownow commented Dec 28, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2018
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 28, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 28, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit f63a104

https://deploy-preview-11929--kubernetes-io-master-staging.netlify.com

@tengqm
Copy link
Contributor

tengqm commented Dec 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 29, 2018
@bpownow
Copy link
Contributor Author

bpownow commented Dec 30, 2018

@tengqm how do i get this approved?

@bpownow
Copy link
Contributor Author

bpownow commented Jan 2, 2019

@MistyHacks do you mind taking a look?

@mdlinville
Copy link
Contributor

mdlinville commented Jan 2, 2019 •
edited
Loading

This looks fine, but I'd prefer it if you'd wrap the lines at 80 characters for ease of reviews when this . content is updated.

/lgtm
/approve
/hold
(to give you a chance to address the feedback)

Just lift the hold when you have done this by making a comment that says /hold cancel. Thanks!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 3, 2019
@bpownow
Copy link
Contributor Author

bpownow commented Jan 3, 2019

thanks @MistyHacks!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2019
@mdlinville
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3478ef2 into kubernetes:master Jan 3, 2019
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
@bpownow
add cni-ipvlan-vpc-k8s (kubernetes#11929)
17f0bcd 
* add cni-ipvlan-vpc-k8s

* Update networking.md
immutableT pushed a commit to immutableT/website that referenced this pull request Jan 9, 2019
@bpownow
add cni-ipvlan-vpc-k8s (kubernetes#11929)
c25cb03 
* add cni-ipvlan-vpc-k8s

* Update networking.md
bsalamat pushed a commit to bsalamat/kubernetes.github.io that referenced this pull request Jan 29, 2019
@bpownow @bsalamat
add cni-ipvlan-vpc-k8s (kubernetes#11929)
9a63ef3 
* add cni-ipvlan-vpc-k8s

* Update networking.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajakavitha1 Rajakavitha1 Awaiting requested review from Rajakavitha1

@thockin thockin Awaiting requested review from thockin

Assignees

@tengqm tengqm

@mdlinville mdlinville

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bpownow @k8sio-netlify-preview-bot @tengqm @mdlinville @k8s-ci-robot