modified confusion of cert and key. #11630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 36c31d5 https://deploy-preview-11630--kubernetes-io-master-staging.netlify.com |
Bradamant3
requested review from
liztio
and removed request for
stewart-yu and
Rajakavitha1
|
@liztio pretty sure this is an excellent catch, but can you PTAL? Thanks! /assign |
|
/lgtm thanks a bunch @oke-py! |
k8s-ci-robot
added
the
lgtm
|
thanks for your review! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mistyhacks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
kychool
pushed a commit
to kychool/website
that referenced
this pull request
Dec 26, 2018
kychool
pushed a commit
to kychool/website
that referenced
this pull request
Dec 26, 2018
immutableT
pushed a commit
to immutableT/website
that referenced
this pull request
Jan 9, 2019
immutableT
pushed a commit
to immutableT/website
that referenced
this pull request
Jan 9, 2019
bsalamat
pushed a commit
to bsalamat/kubernetes.github.io
that referenced
this pull request
Jan 29, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cert and key may be confused in some rows.