Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cron-jobs.md #11512

Merged
merged 9 commits into from
Feb 18, 2019
Merged

Update cron-jobs.md #11512

merged 9 commits into from
Feb 18, 2019

Conversation

k-vishwa
Copy link

@k-vishwa k-vishwa commented Dec 4, 2018

Update to startingDeadlineSeconds concept

Update cron-jobs.md
c7e967b 
Update to startingDeadlineSeconds concept
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2018
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 4, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Dec 4, 2018 •
edited by netlify bot
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e9aa2f0

https://deploy-preview-11512--kubernetes-io-master-staging.netlify.com

@k-vishwa
Copy link
Author

k-vishwa commented Dec 4, 2018 •
edited
Loading

/assign @tfogo Please review

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 4, 2018
soltysh
soltysh suggested changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous wording is correct, you're changing the meaning of the original.

@Rajakavitha1
Copy link
Contributor

Thanks for your PR @k-vishwa !!!! Could you please address the review comments in the PR.

@zparnold
Copy link
Member

@k-vishwa question. Cleaned up a little bit of the grammar, I hope it's still clear what you meant.

@k-vishwa
Copy link
Author

@zparnold Thanks for making the correction.

@tengqm
Copy link
Contributor

tengqm commented Feb 18, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2019
@zparnold
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zparnold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9654ecc into kubernetes:master Feb 18, 2019
kwiesmueller pushed a commit to kwiesmueller/website that referenced this pull request Feb 28, 2019
Update cron-jobs.md (kubernetes#11512)
b05ab02 
* Update cron-jobs.md

Update to startingDeadlineSeconds concept

* Update jobs-run-to-completion.md

Syntax correction

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Mar 11, 2019
Update cron-jobs.md (kubernetes#11512)
083a512 
* Update cron-jobs.md

Update to startingDeadlineSeconds concept

* Update jobs-run-to-completion.md

Syntax correction

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>
yagonobre pushed a commit to yagonobre/website that referenced this pull request Mar 14, 2019
@yagonobre
Update cron-jobs.md (kubernetes#11512)
244d9ad 
* Update cron-jobs.md

Update to startingDeadlineSeconds concept

* Update jobs-run-to-completion.md

Syntax correction

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>

* Update content/en/docs/concepts/workloads/controllers/cron-jobs.md

Co-Authored-By: k-vishwa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@zparnold zparnold zparnold left review comments

@soltysh soltysh soltysh requested changes

@erictune erictune Awaiting requested review from erictune

Assignees

@tfogo tfogo

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@k-vishwa @k8s-ci-robot @k8sio-netlify-preview-bot @Rajakavitha1 @zparnold @tengqm @soltysh @sftim @tfogo