Remove references to imported for Contributing guides #10084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
2 tasks
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 2188f8d https://deploy-preview-10084--kubernetes-io-master-staging.netlify.com |
|
/assign @tengqm @xiangpengzhao |
k8s-ci-robot
added
the
lgtm
|
/approve Thank you! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bradamant3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
krmayankk
pushed a commit
to krmayankk/kubernetes.github.io
that referenced
this pull request
Aug 28, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to open some of Contributor guides results in the error 404 as the website redirects to URLs containing
imported.This PR tries to fix the issue, by modifying the URLs to use the non-
importedURLs. It also adds entries to the redirects file, so accessing viaimportedURLs redirect to the appropriate page.Affected endpoints and possibly correct URL used in this PR:
https://kubernetes.io/docs/imported/community/devel/->https://kubernetes.io/docs/community/devel/,https://kubernetes.io/docs/imported/community/keps/->https://kubernetes.io/docs/community/keps/,https://kubernetes.io/docs/imported/community/guide/->https://kubernetes.io/docs/community/guide/,https://kubernetes.io/docs/imported/community/mentoring/->https://kubernetes.io/docs/community/mentoring/.This is my first PR to k/website, so it may be that I'm wrong, but please let me know if there's a better way to fix this. :)
More details about the issue can be found in #10083.
Closes #10083.