Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with kubectl_get page: horizontal slider broken, and some escaping broken #76

Closed
davidopp opened this issue Mar 8, 2016 · 13 comments
Assignees
Milestone

Comments

@davidopp
Copy link
Member

davidopp commented Mar 8, 2016

http://kubernetes.github.io/docs/user-guide/kubectl/kubectl_get/

the horizontal slider in the "options" section actually doesn't slide, and it looks like the template isn't escaped properly in the line
kubectl get -o template pod/web-pod-13je7 --template= --api-version=v1 (the --template argument shouldn't be empty)

@CreaturesInUnitards
Copy link

David, are you saying you can't get the "options" code section to scroll? If so, I don't repro that — what's your browser?

@davidopp
Copy link
Member Author

davidopp commented Mar 8, 2016

Correct. I'm using Chrome 48.0.2564.116 on Linux.

@CreaturesInUnitards
Copy link

Hm. No repro on Mac Chrome, Safari or Firefox, or Win IE or Chrome.

Chrome just updated to 49.0.2623.75; maybe that takes care of it...?

@johndmulhausen
Copy link

@eparis I've added {% raw %} and {% endraw %} to the examples here; perhaps the auto doc generator should do that for all captured "man" output?

@johndmulhausen johndmulhausen self-assigned this Mar 9, 2016
@johndmulhausen
Copy link

No repro on the horizontal scrollbars not working, sorry. We'll see if Eric knows of an easy way to get {% raw %} tags in on the auto-gen markdown files and then we'll be closing this.

@eparis
Copy link
Contributor

eparis commented Mar 9, 2016

I can confirm the 'can't scroll the options block' using chrome 50 on linux. So at least 2 of us have that problem.

As to {% raw %} it's not a tag I know... Is that something we need inside every code block? Why is this one special? I thought the whole point of was to make it not interpret things....

@johndmulhausen
Copy link

cc @CreaturesInUnitards -- can you test on Chrome Linux?

@eparis - Re: {% raw%}: The triple-tic blocks work for everything except Tags that use the Liquid Tag Syntax. So, {{foo}} and {%bar%}. GitHub Pages pre-processes Liquid Tags before running them through the Markdown processor. That's what's happening on http://kubernetes.github.io/docs/user-guide/kubectl/kubectl_get/ (Or was, before I added the {% raw %} tags so the Liquid processor would leave it alone)

@CreaturesInUnitards
Copy link

investigating...

@eparis
Copy link
Contributor

eparis commented Mar 9, 2016

I'm going to open a new issue about the escaping....

@eparis
Copy link
Contributor

eparis commented Mar 9, 2016

I openned #81 to point out the places my quick grep saw {{ in ``` block problems and to discuss kubectl get

@CreaturesInUnitards
Copy link

@johndmulhausen: this is a problem for Linux Firefox as well. It's the pseudo-elements on H# tags, as it turns out — no amount of z-indexing will get them to go behind the elements that come before them in the DOM. I have a script which will fix this, but there's not a lot of time before launch. Recommend punting to post-launch

@johndmulhausen
Copy link

Assigning to @CreaturesInUnitards to fix the scrolling. That's the only thing this bug is about now.

@CreaturesInUnitards
Copy link

ok fixed

xingzhou pushed a commit to xingzhou/official.kubernetes.github.io that referenced this issue Aug 31, 2017
concepts-overview-working-with-objects-kubernetes-objects-pr-2017-07-15
mikutas pushed a commit to mikutas/k8s-website that referenced this issue Feb 24, 2021
WangXiangUSTC added a commit to WangXiangUSTC/website that referenced this issue Oct 19, 2021
Okabe-Junya pushed a commit to Okabe-Junya/website that referenced this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants