Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments-Kubernetes 1.29 Version Not Recording Command Line Without --record Flag (in kubernetes.io doc can record without --record) #45780

Closed
vcyj opened this issue Apr 5, 2024 · 12 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@vcyj
Copy link

vcyj commented Apr 5, 2024


Kubernetes 1.29 Version Not Recording Command Line Without --record Flag

Bug Report

What happened:

In Kubernetes version 1.29, the command line invocations are not being recorded automatically in the deployment history when operation is performed without the --record flag. After running the kubectl rollout history deployment/nginx-deployment, some of the revisions show "" in the CHANGE-CAUSE column when the operation is performed without --record flag.

Here is an example:

[root@master01 deployment]# kubectl set image deployment.v1.apps/nginx-deployment nginx=nginx:1.16.1
deployment.apps/nginx-deployment image updated
[root@master01 deployment]# kubectl rollout history deployment/nginx-deployment
deployment.apps/nginx-deployment 
REVISION  CHANGE-CAUSE
1         <none>
2         <none>

[root@master01 deployment]# kubectl version
Client Version: v1.29.0
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.0

image

the pic in doc in https://kubernetes.io/docs/concepts/workloads/controllers/deployment

image

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vcyj vcyj changed the title Deployments-Kubernetes 1.29 Version Not Recording Command Line Without --record Flag (in kubernentes.io doc can record without --record) [BUG REPORT] Deployments-Kubernetes 1.29 Version Not Recording Command Line Without --record Flag (in kubernentes.io doc can record without --record) Apr 5, 2024
@T-Lakshmi
Copy link
Contributor

/language zh
/sig docs

@k8s-ci-robot k8s-ci-robot added language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 5, 2024
@T-Lakshmi
Copy link
Contributor

T-Lakshmi commented Apr 5, 2024

Page issue mentioned: https://kubernetes.io/zh-cn/docs/concepts/workloads/controllers/deployment/

@vcyj,
You mention the pic from english version docs and provided chinese localisation docs url.
which one you tried?

@vcyj
Copy link
Author

vcyj commented Apr 6, 2024

Page issue mentioned: https://kubernetes.io/zh-cn/docs/concepts/workloads/controllers/deployment/

@vcyj,
You mention the pic from english version docs and provided chinese localisation docs url.
which one you tried?

Sorry about that.Now i have changed to right doc url

@dipesh-rawat
Copy link
Member

/remove-language zh
/language en

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language and removed language/zh Issues or PRs related to Chinese language labels Apr 7, 2024
@sftim
Copy link
Contributor

sftim commented Apr 10, 2024

/retitle Deployments-Kubernetes 1.29 Version Not Recording Command Line Without --record Flag (in kubernetes.io doc can record without --record)
/kind bug

@k8s-ci-robot k8s-ci-robot changed the title [BUG REPORT] Deployments-Kubernetes 1.29 Version Not Recording Command Line Without --record Flag (in kubernentes.io doc can record without --record) Deployments-Kubernetes 1.29 Version Not Recording Command Line Without --record Flag (in kubernetes.io doc can record without --record) Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 10, 2024
@sftim
Copy link
Contributor

sftim commented Apr 10, 2024

The Deployment concept page is out of date. We're planning to remove the deprecated --record command line argument from the kubectl tool.

We should change https://kubernetes.io/docs/concepts/workloads/controllers/deployment/ to:

  • move the tutorial for managing a Deployment into a separate page
  • explain that CHANGE-CAUSE is a legacy column

IMO, we should also change https://kubernetes.io/docs/reference/labels-annotations-taints/#change-cause to explain its use. If the kubernetes.io/change-cause annotation is deprecated, we should say so.

@sftim
Copy link
Contributor

sftim commented Apr 10, 2024

Also see kubernetes/kubernetes#124259

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 9, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 8, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
Development

No branches or pull requests

6 participants