Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading kubeadm clusters - version notes out of date #44674

Closed
kfox1111 opened this issue Jan 8, 2024 · 8 comments
Closed

Upgrading kubeadm clusters - version notes out of date #44674

kfox1111 opened this issue Jan 8, 2024 · 8 comments
Assignees
Labels
language/en Issues or PRs related to English language sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kfox1111
Copy link
Contributor

kfox1111 commented Jan 8, 2024

Now that this has merged:
kubernetes/kubernetes#120825

The documentation needs to be upgraded to let folks know node versions can be behind more then 1.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 8, 2024
@thisisharrsh
Copy link
Contributor

/language en
/sig docs

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 8, 2024
@thisisharrsh
Copy link
Contributor

@neolit123
Copy link
Member

neolit123 commented Jan 8, 2024

Now that this has merged: kubernetes/kubernetes#120825

The documentation needs to be upgraded to let folks know node versions can be behind more then 1.

it's kubelet versions to be precise, but kubeadm has no way to catch and verify what version of the kubelet the user deployed today. as can be seen in the doc here:
https://kubernetes.io/docs/tasks/administer-cluster/kubeadm/kubeadm-upgrade/
kubelet upgrade happens out-of-band (after kubeadm upgrade has finished).

that's a bit of a design problem...

there were some AIs and some discussion here:
kubernetes/kubeadm#2924
kubernetes/kubeadm#2626

we currently have e2e tests that verify the kubeadm vs kubelet skew, but there are some gotchas around kubelet flags.
i'd claim the whole kubernetes/kubernetes#120825 change as supported, but i'm tentative around calcimining announcing it more widely in the docs.

perhaps we can say something like this in a small note near the top:

@neolit123
Copy link
Member

neolit123 commented Jan 8, 2024

/sig cluster-lifecycle
PRs welcome.

@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jan 8, 2024
@neolit123
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 8, 2024
@pegasas
Copy link
Contributor

pegasas commented Jan 9, 2024

/assign @pegasas
I will raise an PR for fixing this.

@pegasas
Copy link
Contributor

pegasas commented Jan 12, 2024

PR merge.
Request to close this issue.
/close

@k8s-ci-robot
Copy link
Contributor

@pegasas: Closing this issue.

In response to this:

PR merge.
Request to close this issue.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants