Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to find which alpha feature gates for "Resize CPU and Memory Resources assigned to Containers" #40776

Closed
nashtsai opened this issue Apr 19, 2023 · 12 comments · Fixed by #45350
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@nashtsai
Copy link

Not able to find which alpha feature gates for Resize CPU and Memory Resources assigned to Containers

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 19, 2023
@mengjiao-liu
Copy link
Member

/kind feature
/triage accepted

// Resources resize policy for the container.
// +featureGate=InPlacePodVerticalScaling
// +optional
ResizePolicy []ContainerResizePolicy

This field is controlled by the feature gate InPlacePodVerticalScaling.

It looks like we need to add a feature gate description.

Does anyone want to help?
/help

@k8s-ci-robot
Copy link
Contributor

@mengjiao-liu:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/kind feature
/triage accepted

// Resources resize policy for the container.
// +featureGate=InPlacePodVerticalScaling
// +optional
ResizePolicy []ContainerResizePolicy

This field is controlled by the feature gate InPlacePodVerticalScaling.

It looks like we need to add a feature gate description.

Does anyone want to help?
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 20, 2023
@tengqm
Copy link
Contributor

tengqm commented Apr 20, 2023

There is a blog under review. #39846

I do concur that some docs are needed for such an important feature.

@sftim
Copy link
Contributor

sftim commented Apr 20, 2023

We should mention InPlacePodVerticalScaling within https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/#container-resize-policies.

#39845 didn't cover this detail.

@nashtsai
Copy link
Author

InPlacePodVerticalScaling

InPlacePodVerticalScaling in also missing in https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/

@tengqm
Copy link
Contributor

tengqm commented Apr 21, 2023

Fix coming in #40623

@dipankardas011
Copy link
Contributor

dipankardas011 commented Jun 7, 2023

Hi @sftim , @tengqm as I am unable see the changes can I add it to the page?

@tengqm
Copy link
Contributor

tengqm commented Jun 8, 2023

Hi @sftim , @tengqm as I am unable see the changes can I add it to the page?

The feature gate issue has been fixed but the feature description needs some more formal documentation. Please feel free to provide some inputs.

@dipankardas011
Copy link
Contributor

Hi @sftim , @tengqm as I am unable see the changes can I add it to the page?

The feature gate issue has been fixed but the feature description needs some more formal documentation. Please feel free to provide some inputs.

sure so we need to add the featureGate thing?
here https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/

@tengqm
Copy link
Contributor

tengqm commented Jun 8, 2023

Hi @sftim , @tengqm as I am unable see the changes can I add it to the page?

The feature gate issue has been fixed but the feature description needs some more formal documentation. Please feel free to provide some inputs.

sure so we need to add the featureGate thing? here https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/

It is not limited to the feature gate. It is about the feature. We are supposed to provide some brief introduction to this feature. Currently we have some texts on it, but those texts are provided as a blog (see #39846). Some of the blogs could have been part of the docs task page (https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/).

@dipankardas011
Copy link
Contributor

Hi @sftim , @tengqm as I am unable see the changes can I add it to the page?

The feature gate issue has been fixed but the feature description needs some more formal documentation. Please feel free to provide some inputs.

sure so we need to add the featureGate thing? here https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/

It is not limited to the feature gate. It is about the feature. We are supposed to provide some brief introduction to this feature. Currently we have some texts on it, but those texts are provided as a blog (see #39846). Some of the blogs could have been part of the docs task page (https://kubernetes.io/docs/tasks/configure-pod-container/resize-container-resources/).

thanks for clarifying

@dshebib
Copy link
Contributor

dshebib commented Jun 25, 2023

Note that this is the same issue as #41365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants