Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod DNS config example does not use documentation IP address #39166

Closed
sftim opened this issue Jan 30, 2023 · 2 comments · Fixed by #39169
Closed

Pod DNS config example does not use documentation IP address #39166

sftim opened this issue Jan 30, 2023 · 2 comments · Fixed by #39169
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Jan 30, 2023

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config uses 1.2.3.4 as the example DNS server. It's better to use an IP address reserved for documentation.

Proposed Solution:
Change that example manifest and web page to use IP address reserved for documentation.
You need to make the change in two places so that they match up.

Page to Update:

https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/

Additional Information:

/language en
/priority backlog
/help
/triage accepted

/good-first-issue

@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

This is a Bug Report

Problem:
https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config uses 1.2.3.4 as the example DNS server. It's better to use an IP address reserved for documentation.

Proposed Solution:
Change that example manifest and web page to use IP address reserved for documentation.
You need to make the change in two places so that they match up.

Page to Update:

https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/

Additional Information:

/language en
/priority backlog
/help
/triage accepted

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Jan 30, 2023
@reetasingh
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants