Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update the code-contributor.yaml #36721

Closed
amolmote opened this issue Sep 10, 2022 · 9 comments
Closed

Need to update the code-contributor.yaml #36721

amolmote opened this issue Sep 10, 2022 · 9 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@amolmote
Copy link
Member

Issue I have observed with code-contributor.yaml
Issue in the code-contributor.yaml is that the lable: Learn about the Kubernetes Enhancement Proposal (KEP) process it has broken url.
So we need to update it with the right url of KEP.

/language en
/assign

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2022
@k8s-ci-robot
Copy link
Contributor

@amolmote: The label triage/accepted cannot be applied. Only GitHub organization members can add the label.

In response to this:

/triage accepted

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@amolmote
Copy link
Member Author

@sftim, please accept the triage, I want to open pr for this issue

@mtardy
Copy link
Member

mtardy commented Sep 13, 2022

Seems reasonable since the link is broken. I failed to find, do you have any examples of where this data is used? Where did you find out that this link was broken?

/triage accepted
/kind bug

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 13, 2022
@amolmote
Copy link
Member Author

Here is it solution I have already opened pr in community repo
kubernetes/community#6870
Can I open the pr for this as well

@mtardy
Copy link
Member

mtardy commented Sep 13, 2022

Here is it solution I have already opened pr in community repo kubernetes/community#6870 Can I open the pr for this as well

I think you already did here #36735 no?

But, for understanding how this data is used, do you have any examples or you just searched for the broken URL in the repo?

@amolmote
Copy link
Member Author

Actually I am reading the open pr process that time i got this issue and when I have come around this yml by reading the KEP process I thought that this also be a broken link

@amolmote
Copy link
Member Author

by searching broken link you will not get anything because this is the internal part of readme

@amolmote
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@amolmote: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants