Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention PDB updates in PodDisruptionBudget task page #26385

Closed
sftim opened this issue Feb 4, 2021 · 16 comments
Closed

Mention PDB updates in PodDisruptionBudget task page #26385

sftim opened this issue Feb 4, 2021 · 16 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Feb 4, 2021

This is a Feature Request

What would you like to be added
https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets mentions PodDisruptionBudget.

Verify that this documentation is:
- current
- correct
- relevant

Also check whether https://kubernetes.io/docs/tasks/run-application/configure-pdb/ should have any changes in light of improvements such as: kubernetes/kubernetes#69867

Revise https://kubernetes.io/docs/tasks/run-application/configure-pdb/ to mentioning how you can update a PodDisruptionBudget.

Add a section headed eg Update PDB that gives an example of how you can update the configuration of an existing PDB using kubectl.

Why is this needed
PodDisruptionBudget is slated to go GA in v1.21 and PDBs are no longer immutable.

Comments
/language en
/sig apps

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/apps Categorizes an issue or PR as relevant to SIG Apps. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 4, 2021
@kbhawkey
Copy link
Contributor

kbhawkey commented Feb 4, 2021

Is this issue related to issue #22391?

@sftim
Copy link
Contributor Author

sftim commented Feb 4, 2021

Both issues are about the same web page. This issue is about making sure the docs are ready for the PodDisruptionBudget API to graduate to stable.

@kbhawkey
Copy link
Contributor

kbhawkey commented Feb 4, 2021

OK. Possibly address both issues in one PR.
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 4, 2021
@irvifa
Copy link
Member

irvifa commented Feb 6, 2021

/help

@k8s-ci-robot
Copy link
Contributor

@irvifa:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 6, 2021
@sladyn98
Copy link

@sftim In light of these changes kubernetes/kubernetes#69867 it would be great to add a section to this https://kubernetes.io/docs/tasks/run-application/configure-pdb/ like Update PDB and then give an example of how one can update the configuration and then hit kubectl apply which would now apply since the immutability aspect has been removed.Apart from that it looks current 👍

Furthermore https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets looks good since the configuration aspect is not mentioned anywhere in this doc that PR does not affect it. It looks to be current

@sftim
Copy link
Contributor Author

sftim commented Mar 16, 2021

https://kubernetes.io/docs/concepts/workloads/pods/disruptions/#pod-disruption-budgets … looks to be current

Thanks, that's useful to know.

[adding a section to https://kubernetes.io/docs/tasks/run-application/configure-pdb/]

That sounds like a good idea. Thanks.

@sftim
Copy link
Contributor Author

sftim commented Mar 16, 2021

/retitle Mention PDB updates in PodDisruptionBudget task page

@k8s-ci-robot k8s-ci-robot changed the title Review and improve Pod disruptions concept Mention PDB updates in PodDisruptionBudget task page Mar 16, 2021
@sladyn98
Copy link

I can probably add this

@sftim
Copy link
Contributor Author

sftim commented Mar 16, 2021

Cool, thanks @sladyn98!

@sftim
Copy link
Contributor Author

sftim commented Mar 16, 2021

Relevant to #27053

@sladyn98
Copy link

@sftim #16738 Looks like this PR already added the update section, however it was added under the heading Create PDB Object which kind of cause me to miss it. So it looks good overall.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 15, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. language/en Issues or PRs related to English language lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants