Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes v1.19 - Doc Reference Page has mismatch links #25548

Closed
Goclipse27 opened this issue Dec 10, 2020 · 13 comments
Closed

Kubernetes v1.19 - Doc Reference Page has mismatch links #25548

Goclipse27 opened this issue Dec 10, 2020 · 13 comments
Assignees
@kbhawkey
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Goclipse27
Copy link
Contributor

Problem :
In the v1.19 version of the Kubernetes site - https://v1-19.docs.kubernetes.io/docs/reference/, we are seeing the link for Kubernetes API - https://v1-19.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.20/

Steps to Reproduce :

  1. Navigate to the URL: https://kubernetes.io/ and in the versions choose v1.19
    2.It will be redirected to https://v1-19.docs.kubernetes.io/
    3.Documentation -> reference, under API Reference section we are able to spot a wrong link for v1.20 Kubernetes API Reference v1.20

Solution :
https://v1-19.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/ is the correct Kubernetes API Reference for v1.19 and the link has to be re-titled as Kubernetes API Reference v1.19

Note: As the further older doc versions are not maintained, not sure if it has to be fixed in those as well.
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 10, 2020
@savitharaghunathan
Copy link
Member

/triage accepted
/kind bug

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/bug Categorizes issue or PR as related to a bug. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2020
@sftim
Copy link
Contributor

sftim commented Dec 10, 2020

/priority important-soon
@annajung FYI

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 10, 2020
@sftim
Copy link
Contributor

sftim commented Dec 10, 2020

This looks like a metadata bug, but I'm not exactly sure where the fix is (as I haven't yet investigated)

@sftim
Copy link
Contributor

sftim commented Dec 10, 2020

The behavior seen here (linking to the current API reference) has come from #18837

@sftim sftim mentioned this issue Dec 10, 2020
Merged
@kbhawkey
Copy link
Contributor

👀

@kbhawkey
Copy link
Contributor

The config.toml in the release-1.19 branch should set latest to 1.19.
The shortcode uses, {{ site.Params.latest }} and this variable is set to 1.20.

@kbhawkey
Copy link
Contributor

I can fix this.

@kbhawkey
Copy link
Contributor

/assign

@kbhawkey kbhawkey mentioned this issue Dec 11, 2020
Merged
@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 11, 2020 •
edited
Loading

The 1.18, 1.17 branches appear to depend on the latest parameter as well.

This was referenced Dec 11, 2020
Merged
Merged
@sftim sftim mentioned this issue Dec 11, 2020
Merged
@kbhawkey
Copy link
Contributor

Hi @raghvenders .
What do you think about closing this issue?

@tengqm
Copy link
Contributor

tengqm commented Dec 17, 2020

Feel free to reopen if the issue is still there.
/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closing this issue.

In response to this:

Feel free to reopen if the issue is still there.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Goclipse27
Copy link
Contributor Author

@kbhawkey - Thanks for fixing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbhawkey kbhawkey

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kbhawkey @tengqm @savitharaghunathan @Goclipse27 @k8s-ci-robot @sftim