Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-Side Apply listType documentation is inconsistent #25153

Closed
TBBle opened this issue Nov 21, 2020 · 3 comments · Fixed by #25155
Closed

Server-Side Apply listType documentation is inconsistent #25153

TBBle opened this issue Nov 21, 2020 · 3 comments · Fixed by #25155
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@TBBle
Copy link
Contributor

TBBle commented Nov 21, 2020

In the Merge Strategy section, the //+listType annotation documentation gives possible values of atomic/set/map, but the description describes atomic and granular.

There's a more-detailed behaviour description in #16725 which might be useful to draw from.
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 21, 2020
@apelisse
Copy link
Member

Good point, let me send a quick fix.

@apelisse
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 21, 2020
apelisse pushed a commit to apelisse/kubernetes.github.io that referenced this issue Nov 21, 2020
Replace incorrect granular by set/map.
4aa1c92 
Fixes kubernetes#25153
@apelisse apelisse mentioned this issue Nov 21, 2020
Merged
@sftim
Copy link
Contributor

sftim commented Nov 22, 2020

/kind cleanup
/language en

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language labels Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. language/en Issues or PRs related to English language triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace incorrect granular by set/map apelisse/kubernetes.github.io
4 participants
@TBBle @apelisse @k8s-ci-robot @sftim