Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation conflict regarding postStart #17795

Closed
jjulien opened this issue Nov 25, 2019 · 8 comments
Closed

Documentation conflict regarding postStart #17795

jjulien opened this issue Nov 25, 2019 · 8 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@jjulien
Copy link

jjulien commented Nov 25, 2019

This is a Bug Report

Problem:
Documentation exists that states a container enters a "running" status prior to executing "postStart" hooks. Other documentation, and observed behavior, states a pod does not enter a "running" status until after "postStart" hooks complete.

Proposed Solution:
Fix the documentation to reflect current behavior.

Currently reads

Once a container enters into Running, postStart hook (if any) is executed. This state also displays the time when the container entered Running state.

Should read

The postStart hook (if any) is executed prior to the container entering a Running state. This state also displays the time when the container entered Running state.

Current observed behavior is documented here
https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/#discussion

The Container’s status is not set to RUNNING until the postStart handler completes.

Page to Update:
https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#container-states

@sftim
Copy link
Contributor

sftim commented Nov 30, 2019

@jjulien would you be willing to replace the pictures of hyperlinks with the URLs as text? That'll help people who want to follow those links.

(you can edit the description of your issue)

@jjulien
Copy link
Author

jjulien commented Nov 30, 2019

Yea, I don't know what was going on when I created this. It automatically created those images when I tried to paste in the URLs. They should work now.

@sftim
Copy link
Contributor

sftim commented Dec 9, 2019

Thanks @jjulien
/priority backlog
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Thanks @jjulien
/priority backlog
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 9, 2019
@rajattrt
Copy link
Contributor

rajattrt commented Jan 3, 2020

I will try to pick this one.
/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2020
@rajattrt
Copy link
Contributor

rajattrt commented Apr 9, 2020

/close

@k8s-ci-robot
Copy link
Contributor

@rajattrt: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

5 participants