Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch PowerShell example does not work on Windows #17630

Closed
lfshr opened this issue Nov 18, 2019 · 4 comments · Fixed by #17645
Closed

Patch PowerShell example does not work on Windows #17630

lfshr opened this issue Nov 18, 2019 · 4 comments · Fixed by #17645
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/windows Categorizes an issue or PR as relevant to SIG Windows.

Comments

@lfshr
Copy link

lfshr commented Nov 18, 2019 •
edited
Loading

This is a Bug Report

kubectl PowerShell example does not work in Windows. cat is an alias for Get-Content, which by default parses a file line-by-line.

Proposed Solution:
Change PowerShell example to use the -Raw flag in Get-Content cmdlet (and change cat to Get-Content to avoid ambiguity between the Windows Get-Command alias and Unix cat command).

kubectl patch deployment patch-demo --patch $(Get-Content patch-file.yaml -Raw)

Page to Update:
https://kubernetes.io/docs/tasks/run-application/update-api-object-kubectl-patch/
@aimeeu
Copy link
Contributor

aimeeu commented Nov 18, 2019

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Nov 18, 2019
@sftim
Copy link
Contributor

sftim commented Nov 18, 2019

Seems like a valid fix
/priority backlog
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@sftim:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Seems like a valid fix
/priority backlog
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Nov 18, 2019
@lojies lojies mentioned this issue Nov 19, 2019
Merged
@rashmi43
Copy link

I would like to take this up.

@kubernetes kubernetes deleted a comment from unyilmelenoyska Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change PowerShell example to use the -Raw flag lojies/kubernetes.github.io
5 participants
@lfshr @rashmi43 @k8s-ci-robot @sftim @aimeeu