Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with the header nav under Documentation tab #12826

Closed
1 of 2 tasks
daminisatya opened this issue Feb 25, 2019 · 6 comments · Fixed by #14807
Closed
1 of 2 tasks

Issue with the header nav under Documentation tab #12826

daminisatya opened this issue Feb 25, 2019 · 6 comments · Fixed by #14807
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@daminisatya
Copy link
Contributor

This is a...

  • Feature Request
  • Bug Report

Problem:
Navigate from the home page of the website to Documentation which will land you over here.

screen shot 1940-12-06 at 8 03 16 pm

One can observe extra padding under the navigation tabs. But it's the not same when you navigate to the Setup/ any other tab other than Home. Refer the below screenshot.

screen shot 1940-12-06 at 8 03 34 pm

Proposed Solution:

Navbar padding (Home tab) must be consistent with other tabs.

Page to Update:
https://kubernetes.io/docs/home/
@daminisatya
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@daminisatya:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 25, 2019
@Abhik1998
Copy link
Contributor

I wanted to show a sample of how you wanted it to be.
image

@Abhik1998
Copy link
Contributor

Is this ok??

Abhik1998 added a commit to Abhik1998/website that referenced this issue Feb 26, 2019
@Abhik1998
Updating file after removing extra padding.
cdf6b8b 
Addressing to issue kubernetes#12826
@Abhik1998 Abhik1998 mentioned this issue Feb 26, 2019
Closed
This was referenced Mar 5, 2019
Closed
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 27, 2019
@kbhawkey kbhawkey mentioned this issue Jun 10, 2019
Merged
@kbhawkey
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
5 participants
@kbhawkey @daminisatya @k8s-ci-robot @fejta-bot @Abhik1998