Skip to content

Commit

Permalink
Fixes PDB rounding docs (percentage as string instead of float) (#14788)
Browse files Browse the repository at this point in the history
* Clarifies how to set `minAvailable` using a percentage

* Fixes other references to percentages
  • Loading branch information
jasongwartz authored and tengqm committed Jun 10, 2019
1 parent 8f4fe15 commit 1f9786e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions content/en/docs/tasks/run-application/configure-pdb.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,12 @@ Values for `minAvailable` or `maxUnavailable` can be expressed as integers or as

- When you specify an integer, it represents a number of Pods. For instance, if you set `minAvailable` to 10, then 10
Pods must always be available, even during a disruption.
- When you specify a percentage by setting the value to a floating-point value between 0 and 1, it represents a percentage of
total Pods. For instance, if you set `minUnavailable` to `.5`, then only 50% of the Pods can be unavailable during a
- When you specify a percentage by setting the value to a string representation of a percentage (eg. `"50%"`), it represents a percentage of
total Pods. For instance, if you set `minUnavailable` to `"50%"`, then only 50% of the Pods can be unavailable during a
disruption.

When you specify the value as a percentage, it may not map to an exact number of Pods. For example, if you have 7 Pods and
you set `minAvailable` to `.5`, it's not immediately obvious whether that means 3 Pods or 4 Pods must be available.
you set `minAvailable` to `"50%"`, it's not immediately obvious whether that means 3 Pods or 4 Pods must be available.
Kubernetes rounds up to the nearest integer, so in this case, 4 Pods must be available. You can examine the
[code](https://github.com/kubernetes/kubernetes/blob/23be9587a0f8677eb8091464098881df939c44a9/pkg/controller/disruption/disruption.go#L539)
that controls this behavior.
Expand Down

0 comments on commit 1f9786e

Please sign in to comment.