Ignore xfs dirty logs #144
Conversation
Signed-off-by: Lou <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 27149chen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @gnufied |
|
/assign @saad-ali |
|
/cc @nktpro |
|
@27149chen: GitHub didn't allow me to request PR reviews from the following users: nktpro. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @ jsafrane |
| case xfsRepairErrorsDirtyLogs: | ||
| // mark the a dirty log issue as a warning, do you replay it by default. | ||
| klog.Warningf("A dirty log is detected on this xfs disk.") | ||
| return nil |
There was a problem hiding this comment.
Hi I came across this pr because I do have exactly this problem using ceph rbd with xfs and rook.io
Wouldn't this cause the same potential "compounding of problems" as in #132 ?
There was a problem hiding this comment.
yes, I will. But 132 is still under discussion.
|
/assign @dims |
|
@27149chen: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
k8s-ci-robot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR try to fix the urgent issue #141 by ignoring the xfs dirty logs issue (do not replay dirty logs by default), and letting subsequent operations handle it.
But this is not a perfect solution, more discussion is in pr #132 .