Add dep + remove etcd to/from cluster api docker image #9874

alvaroaleman · 2018-10-20T19:45:37Z

k8s-ci-robot · 2018-10-20T19:45:37Z

Welcome @alvaroaleman! It looks like this is your first PR to kubernetes/test-infra 🎉🎉

alvaroaleman · 2018-10-20T19:46:24Z

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml

+      preset-service-account: "true"
+    spec:
+      containers:
+      - image: gcr.io/k8s-testimages/cluster-api:v20181020-5ce477da2


@roberthbailey Wo builds this image? The tag I used is only correct if it will be built today at commit 5ce477d.

Does it work like this or do I have to do two prs, one for the image change, one for the presubmit?

@BenTheElder can confirm but I think you can do it in one commit as long as the new image has already been pushed with the relevant changes inside of it.

Also, you should update the image in the other tests so that we use the same image everywhere.

@BenTheElder can confirm but I think you can do it in one commit as long as the new image has already been pushed with the relevant changes inside of it

Yeah but who does push it? I see no job on the pull that does it.

I'll update the tags for the other images when I know what it should be.

I might have permissions to push it, but @BenTheElder certainly will.

sorry for the delay, my inbox is RIP..

I have no idea who maintains this image.. looks like krousey?

test-infra/images/cluster-api/Dockerfile

Line 17 in be2f242

LABEL maintainer="[email protected]"

These are not auto pushed. I can push one though, and I'm pretty sure you have permissions @roberthbailey

@roberthbailey Could you please push an image with my changes and tell me the tag, so I can update the PR and we can merge it?

roberthbailey · 2018-10-21T04:35:08Z

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml

+      preset-service-account: "true"
+    spec:
+      containers:
+      - image: gcr.io/k8s-testimages/cluster-api:v20181020-5ce477da2


@BenTheElder can confirm but I think you can do it in one commit as long as the new image has already been pushed with the relevant changes inside of it.

roberthbailey · 2018-10-21T04:36:12Z

config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits.yaml

+      preset-service-account: "true"
+    spec:
+      containers:
+      - image: gcr.io/k8s-testimages/cluster-api:v20181020-5ce477da2


Also, you should update the image in the other tests so that we use the same image everywhere.

roberthbailey · 2018-10-21T04:37:36Z

images/cluster-api/Dockerfile

@@ -23,9 +23,16 @@ ENV IMAGE=${IMAGE_ARG}
 ENV ETCD_VER=v3.3.0


I'm not sure we need to download & install etcd any longer. It would be useful to see if we can take it out and still have our tests pass. No need to do it as part of this PR, but could you file an issue to follow up on it?

Opened kubernetes-sigs/cluster-api#555 for that

fejta · 2018-12-14T05:32:06Z

@roberthbailey @BenTheElder is this waiting for another review?

BenTheElder · 2018-12-19T23:43:59Z

this one is a bit akward because it has both an image change and depending on that image at the same time, one of us will need to check out at the image change and push it.

@alvaroaleman do you think you could split the PR out? at some point we'll probably automate the image pushes but even manually it's a little easier to just sync after the first PR and push the image

roberthbailey · 2019-01-11T21:07:12Z

It looks like the PR is now just changing the dockerfile, which looks good to me.

/lgtm

k8s-ci-robot · 2019-01-11T21:07:16Z

LGTM label has been added.

Git tree hash: 7d7094569b181963a60c1004b6caae7c8ffd64a6

alvaroaleman · 2019-01-11T21:07:47Z

@BenTheElder Yes, I removed the commit that adds the presubmit so the PR now only changes the image. I will create a follow-up that adds the new presubmit and bumps the image in all existing presubmits.

@roberthbailey Can you approve, please?

roberthbailey · 2019-01-11T21:08:24Z

/approve

BenTheElder

/approve

k8s-ci-robot · 2019-01-11T23:04:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, BenTheElder, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~images/OWNERS~~ [BenTheElder]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BenTheElder · 2019-01-14T20:01:51Z

sorry caught back up to this, will look at the image today.

BenTheElder · 2019-01-14T20:07:03Z

v20190114-652973a54 should be pushed after a make -C images/cluster-api push

k8s-ci-robot assigned roberthbailey Oct 20, 2018

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2018

k8s-ci-robot requested review from mithrav and roberthbailey October 20, 2018 19:45

k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 20, 2018

alvaroaleman commented Oct 20, 2018

View reviewed changes

alvaroaleman force-pushed the cluster-api-dep-presubmit branch from 13d4de5 to edff400 Compare October 20, 2018 19:56

k8s-ci-robot added the area/testgrid label Oct 20, 2018

alvaroaleman force-pushed the cluster-api-dep-presubmit branch from edff400 to 7e2ec25 Compare October 20, 2018 20:05

roberthbailey reviewed Oct 21, 2018

View reviewed changes

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2018

alvaroaleman force-pushed the cluster-api-dep-presubmit branch from 7e2ec25 to b245a72 Compare October 31, 2018 12:51

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 31, 2018

alvaroaleman mentioned this pull request Dec 5, 2018

Run more automated checks on cluster-api repo kubernetes-sigs/cluster-api#43

Closed

5 tasks

alvaroaleman force-pushed the cluster-api-dep-presubmit branch from b245a72 to 2936aa9 Compare January 11, 2019 21:03

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2019

Add dep to cluster-api image

f6a93b0

alvaroaleman force-pushed the cluster-api-dep-presubmit branch from 2936aa9 to f6a93b0 Compare January 11, 2019 21:04

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2019

alvaroaleman changed the title ~~Cluster api dep presubmit that checks dependencies~~ Add dep + remove etcd to/from cluster api docker image Jan 11, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2019

BenTheElder approved these changes Jan 11, 2019

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2019

k8s-ci-robot merged commit 2a90eab into kubernetes:master Jan 11, 2019

alvaroaleman mentioned this pull request Jan 12, 2019

Add cluster-api presubmit to check for deps #10729

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add dep + remove etcd to/from cluster api docker image #9874

Add dep + remove etcd to/from cluster api docker image #9874

alvaroaleman commented Oct 20, 2018

k8s-ci-robot commented Oct 20, 2018

alvaroaleman Oct 20, 2018

roberthbailey Oct 21, 2018

roberthbailey Oct 21, 2018

alvaroaleman Oct 21, 2018

roberthbailey Oct 22, 2018

BenTheElder Oct 24, 2018

alvaroaleman Oct 31, 2018

roberthbailey Oct 21, 2018

roberthbailey Oct 21, 2018

roberthbailey Oct 21, 2018

alvaroaleman Oct 21, 2018

fejta commented Dec 14, 2018

BenTheElder commented Dec 19, 2018

roberthbailey commented Jan 11, 2019

k8s-ci-robot commented Jan 11, 2019

alvaroaleman commented Jan 11, 2019

roberthbailey commented Jan 11, 2019

BenTheElder left a comment

k8s-ci-robot commented Jan 11, 2019

BenTheElder commented Jan 14, 2019

BenTheElder commented Jan 14, 2019

		@@ -23,9 +23,16 @@ ENV IMAGE=${IMAGE_ARG}
		ENV ETCD_VER=v3.3.0

Add dep + remove etcd to/from cluster api docker image #9874

Add dep + remove etcd to/from cluster api docker image #9874

Conversation

alvaroaleman commented Oct 20, 2018

k8s-ci-robot commented Oct 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fejta commented Dec 14, 2018

BenTheElder commented Dec 19, 2018

roberthbailey commented Jan 11, 2019

k8s-ci-robot commented Jan 11, 2019

alvaroaleman commented Jan 11, 2019

roberthbailey commented Jan 11, 2019

BenTheElder left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 11, 2019

BenTheElder commented Jan 14, 2019

BenTheElder commented Jan 14, 2019