-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS EBS CSI driver to prow job #9872
Conversation
Welcome @leakingtapan! It looks like this is your first PR to kubernetes/test-infra 🎉🎉 |
please use podutil rather than good-old bootstrap to make new jobs :-) ref https://github.com/kubernetes/test-infra#create-a-new-job a good example you can copy-paste from: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-openstack/cluster-api-provider-openstack-presubmits.yaml |
/assign @krzyzacy |
config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml
Outdated
Show resolved
Hide resolved
1cb96f0
to
c816e3b
Compare
job config lgtm last comment is add a trigger entry for your repo to https://github.com/kubernetes/test-infra/blob/master/prow/plugins.yaml |
Added trigger entry. Let me know if this is good. Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 8ad6bfe0fcd338ebbf88bed0ebbb9ccad043c395
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krzyzacy, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@leakingtapan: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ref #9814
Ref kubernetes-sigs/aws-ebs-csi-driver#36