-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prow jobs for new Kubeflow repositories: #6779
Conversation
c791f30
to
85fd6c6
Compare
preset-service-account: true | ||
spec: | ||
containers: | ||
- image: gcr.io/kubeflow-ci/test-worker:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you link to the image Dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Dockerfile is here
https://github.com/kubeflow/testing/blob/master/images/Dockerfile
What do you mean by link to the Dockerfile? Do you mean add it in a comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, was curious how it works with git checkout, and looking if that's possible to integrate with our checkout procedures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do your git checkout procedures work?
kubeflow/examples kubeflow/testing kubeflow/tf-operator kubeflow/reporting Remove references to tensorflow/k8s repository.
f1e6b82
to
b03be4e
Compare
@krzyzacy I removed references to tensorflow/k8s because that repo has moved to kubeflow/tf-operator. I rebased. PTAL. |
@jlewi we are currently using https://github.com/kubernetes/test-infra/blob/master/jenkins/bootstrap.py, and will move to an init container later this should be fine, assume you've configured webhooks already? If so feel free to |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, krzyzacy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these OWNERS Files:
Approvers can indicate their approval by writing |
@krzyzacy yes we have webhooks enabled at the org level. |
/hold cancel |
@jlewi: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Define pre and postsubmit jobs for the following repositories.
kubeflow/examples
kubeflow/testing
kubeflow/tf-operator
kubeflow/reporting
remove tensorflow/k8s because this has been moved to kubeflow/tf-operator.
Move tensorflow/k8s to kubeflow/tf-operator kubeflow/training-operator#350
We don't add periodic jobs right now; we might add these in the future.