Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prow jobs for new Kubeflow repositories: #6779

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Feb 11, 2018

Define pre and postsubmit jobs for the following repositories.

kubeflow/examples
kubeflow/testing
kubeflow/tf-operator
kubeflow/reporting

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 11, 2018
@jlewi jlewi mentioned this pull request Feb 11, 2018
preset-service-account: true
spec:
containers:
- image: gcr.io/kubeflow-ci/test-worker:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you link to the image Dockerfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile is here
https://github.com/kubeflow/testing/blob/master/images/Dockerfile

What do you mean by link to the Dockerfile? Do you mean add it in a comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, was curious how it works with git checkout, and looking if that's possible to integrate with our checkout procedures

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do your git checkout procedures work?

kubeflow/examples
kubeflow/testing
kubeflow/tf-operator
kubeflow/reporting

Remove references to tensorflow/k8s repository.
@jlewi
Copy link
Contributor Author

jlewi commented Feb 12, 2018

@krzyzacy I removed references to tensorflow/k8s because that repo has moved to kubeflow/tf-operator. I rebased. PTAL.

@krzyzacy
Copy link
Member

@jlewi we are currently using https://github.com/kubernetes/test-infra/blob/master/jenkins/bootstrap.py, and will move to an init container later

this should be fine, assume you've configured webhooks already? If so feel free to /hold cancel
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these OWNERS Files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Feb 12, 2018

@krzyzacy yes we have webhooks enabled at the org level.

@jlewi
Copy link
Contributor Author

jlewi commented Feb 12, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 37f833e into kubernetes:master Feb 12, 2018
@k8s-ci-robot
Copy link
Contributor

@jlewi: Updated the following 2 configmaps:

  • config
  • plugins

In response to this:

Define pre and postsubmit jobs for the following repositories.

kubeflow/examples
kubeflow/testing
kubeflow/tf-operator
kubeflow/reporting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants