Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TIP of dep for installing hg command #6043

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Add TIP of dep for installing hg command #6043

merged 1 commit into from
Dec 20, 2017

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Dec 20, 2017

fixes #5987

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2017
@oomichi oomichi mentioned this pull request Dec 20, 2017
Closed
@BenTheElder
Copy link
Member

/ok-to-test
I remember hitting this now! If you're on a relatively fresh machine there's a good chance you don't have mercurial installed and dep just hangs badly, we should probably file an upstream bug to probe for hg in the path or something 🤔

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 20, 2017
@BenTheElder BenTheElder requested a review from cblecker December 20, 2017 18:19
@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2017
@oomichi
Copy link
Member Author

oomichi commented Dec 20, 2017

@BenTheElder Yeah, you are right. The issue can be reproduced on new environment.
I think the root issue is dep ensure doesn't output any error message which explains what is wrong.
So I will report the issue to upstream of dep or hg also.

@BenTheElder BenTheElder mentioned this pull request Dec 20, 2017
Closed
BenTheElder
BenTheElder approved these changes Dec 20, 2017
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, cblecker, oomichi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2017
@k8s-ci-robot k8s-ci-robot merged commit ff14892 into kubernetes:master Dec 20, 2017
@oomichi oomichi deleted the add-dep-memo branch January 8, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder approved these changes

@cblecker cblecker Awaiting requested review from cblecker

Assignees

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dep ensure never comes back
4 participants
@oomichi @BenTheElder @cblecker @k8s-ci-robot