Set the right kubelet version for the kubeadm PR job #4705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
Comment too long, pylint not happy /shrug |
luxas
force-pushed
the
fix_kubeadm_pull
branch
from
5b81936 to
96119d3
Compare
| @@ -578,6 +578,13 @@ def main(args): | |||
| '--kubernetes-anywhere-kubeadm-version=%s' % version, | |||
| ]) | |||
|
|
|||
| if args.kubeadm == "pull": | |||
There was a problem hiding this comment.
I anticipate you will get a push not to do this in scenarios but rather to do this in kubetest (ie. https://github.com/kubernetes/test-infra/blob/master/kubetest/anywhere.go).
Idea: maybe we should support something like "kubeadm" in addition to "stable" and gs:// link for kubernetesAnywhereKubeletVersion where "kubeadm" means to match the version of kubeadm in anywhere.go.
There was a problem hiding this comment.
Yeah, I also want to get this out of scenarios eventually.
But for now, I want to get it working first.
|
I will not block since it is blocking PRs but do consider the suggestion placing this logic in anywhere.go. /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jessicaochen @pipejakob @krzyzacy
This is needed so that the PR job actually uses the kubelet & other debs from the PR, not post-commit
ci/latest