Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable approval handler for kops SQ and gate on approval. #3651

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

cjwagner
Copy link
Member

There is already an OWNERS file in the kops repo, but the "approved" label needs to be created for the repo. The label will be automatically created by the submit-queue once this PR is merged and deployed, but kubernetes/kops#3042 must be merged first.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 24, 2017
@cjwagner
Copy link
Member Author

/cc @rmmh

@k8s-ci-robot k8s-ci-robot requested a review from rmmh July 24, 2017 21:29
@cjwagner
Copy link
Member Author

/test all

@rmmh
Copy link
Contributor

rmmh commented Jul 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2017
@cjwagner cjwagner merged commit 3aa124f into kubernetes:master Jul 24, 2017
@cjwagner cjwagner deleted the kops-approval branch July 24, 2017 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants