-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
splitfs-separate-disk-kubetest2: use empty skip-regex #34005
splitfs-separate-disk-kubetest2: use empty skip-regex #34005
Conversation
Default value of the --skip-regex option is "\[Flaky\]|\[Slow\]|\[Serial\]" in kubetest2, which resulted in skipping 2 slow serial test cases from the test run. Using empty skip-regex should make amount of test cases the same as for kubernetes_e2e.py splitfs-separate-disk job.
@bart0sh: GitHub didn't allow me to request PR reviews from the following users: elieser1101. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Should we switch these jobs to use label filters? |
Yes, we should, but only after it's supported by |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bart0sh, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bart0sh: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Default value of the
--skip-regex
option is\[Flaky\]|\[Slow\]|\[Serial\]
inkubetest2
, which resulted in skipping 2 slow serial test cases from the test run. Using emptyskip-regex
should make amount of test cases the same as forkubernetes_e2e.py splitfs-separate-disk
job.Ref: #32567
/sig node
/cc @elieser1101 @kannon92 @haircommander