Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitfs-separate-disk-kubetest2: use empty skip-regex #34005

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Dec 18, 2024

Default value of the --skip-regex option is \[Flaky\]|\[Slow\]|\[Serial\] in kubetest2, which resulted in skipping 2 slow serial test cases from the test run. Using empty skip-regex should make amount of test cases the same as for kubernetes_e2e.py splitfs-separate-disk job.

Ref: #32567

/sig node
/cc @elieser1101 @kannon92 @haircommander

Default value of the --skip-regex option is "\[Flaky\]|\[Slow\]|\[Serial\]"
in kubetest2, which resulted in skipping 2 slow serial test cases from
the test run. Using empty skip-regex should make amount of test cases
the same as for kubernetes_e2e.py splitfs-separate-disk job.
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Dec 18, 2024
@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: elieser1101.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Default value of the --skip-regex option is \[Flaky\]|\[Slow\]|\[Serial\] in kubetest2, which resulted in skipping 2 slow serial test cases from the test run. Using empty skip-regex should make amount of test cases the same as for kubernetes_e2e.py splitfs-separate-disk job.

Ref: #32567

/sig node
/cc @elieser1101 @kannon92 @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 18, 2024
@kannon92
Copy link
Contributor

Should we switch these jobs to use label filters?

@bart0sh
Copy link
Contributor Author

bart0sh commented Dec 19, 2024

Should we switch these jobs to use label filters?

Yes, we should, but only after it's supported by kubetest2, right?

@kannon92
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit c2aeed0 into kubernetes:master Dec 19, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@bart0sh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Default value of the --skip-regex option is \[Flaky\]|\[Slow\]|\[Serial\] in kubetest2, which resulted in skipping 2 slow serial test cases from the test run. Using empty skip-regex should make amount of test cases the same as for kubernetes_e2e.py splitfs-separate-disk job.

Ref: #32567

/sig node
/cc @elieser1101 @kannon92 @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants