Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-crio-cgrpv2-imagefsfs-e2e-kubetest2: use n1-standard-4 machine #33944

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Dec 13, 2024

Decreasing parallelism for this job in the #33929 helped, but not fully fixed the issue. It also increased job run time significantly. Let's try to use bigger instance.

Note: this is a test PR, it doesn't guarantee the expected effect as I can't reproduce the issue in my setup.

Ref: ##32567 (comment) kubernetes/kubernetes#127831

/sig node
/cc @elieser1101 @kannon92 @haircommander

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

@bart0sh: GitHub didn't allow me to request PR reviews from the following users: elieser1101.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Decreasing parallelism for this job in the #33929 helped, but not fully fixed the issue. It also increased job run time significantly. Let's try to use bigger instance.

Note: this is a test PR, it doesn't guarantee the expected effect as I can't reproduce the issue in my setup.

Ref: ##32567 (comment) kubernetes/kubernetes#127831

/sig node
/cc @elieser1101 @kannon92 @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 13, 2024
@kannon92
Copy link
Contributor

This is only impacting the imagefs job so I think this is fine.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit b50abc0 into kubernetes:master Dec 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants