Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional presubmit job to run apidiff on the client-go module #33866

Merged
merged 1 commit into from
Dec 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions config/jobs/kubernetes/sig-testing/apidiff.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,40 @@ presubmits:
cpu: 2
memory: 12Gi

- name: pull-kubernetes-apidiff-client-go
cluster: eks-prow-build-cluster
# A job which automatically runs for changes in client-go or the generated code
# to have visibility on the changes that will impact the external projects
# that are using the Kubernetes golang clients
run_if_changed: '(^staging\/src\/k8s.io\/client-go)|(^staging\/src\/k8s.io\/code-generator\/examples)'
optional: true
decorate: true
annotations:
# The apidiff.sh script uses the latest revision of apidiff.
# There is no guarantee that this will continue to work for
# older branches, so let's not even create per-release
# copies of this job.
fork-per-release: "false"
testgrid-dashboards: sig-testing-misc
testgrid-create-test-group: 'true'
path_alias: k8s.io/kubernetes
spec:
containers:
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20241128-8df65c072f-master
command:
- runner.sh
args:
- /bin/sh
- -c
- "./hack/apidiff.sh ./staging/src/k8s.io/code-generator/examples ./staging/src/k8s.io/client-go"
resources:
# Memory limits are derived from pull-kubernetes-verify, with less CPUs.
limits:
cpu: 2
memory: 12Gi
requests:
cpu: 2
memory: 12Gi

# A periodic job which shows API diffs for staging repos since the last release
# might be useful. Not done yet.