Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sig-etcd job for raft arm64 presubmits #33715

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Oct 23, 2024

etcd-io/raft currently has a GitHub actions presubmit to run tests against arm64 using actuated.dev arm64 runners https://github.com/etcd-io/raft/blob/main/.github/workflows/test_arm64.yaml

Funding for these runners is no longer available beyond the end of this month so we need to migrate the job to prow as the job will stop working.

The same applies to arm64 actuated jobs in etcd-io/bbolt. I will raise separate pull request(s) for those.

cc @ahrtr, @ivanvc

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/jobs labels Oct 23, 2024
@k8s-ci-robot k8s-ci-robot added sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 23, 2024
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, James.

The same applies to arm64 actuated jobs in etcd-io/bbolt. I will raise separate pull request(s) for those.

Let me know if you want help with any of these. I believe we'll also need to update etcd's release-3.5 branch: https://github.com/etcd-io/etcd/blob/8c162bd06d5f2b384de8994a75239db7dd98f741/.github/workflows/tests.yaml#L16-L25

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1e6fb63 into kubernetes:master Oct 23, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@jmhbnz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key etcd-raft-presubmits.yaml using file config/jobs/etcd/etcd-raft-presubmits.yaml

In response to this:

etcd-io/raft currently has a GitHub actions presubmit to run tests against arm64 using actuated.dev arm64 runners https://github.com/etcd-io/raft/blob/main/.github/workflows/test_arm64.yaml

Funding for these runners is no longer available beyond the end of this month so we need to migrate the job to prow as the job will stop working.

The same applies to arm64 actuated jobs in etcd-io/bbolt. I will raise separate pull request(s) for those.

cc @ahrtr, @ivanvc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/etcd Categorizes an issue or PR as relevant to SIG Etcd. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants