Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable Evented PLEG for ci-kubernetes-node-e2e-containerd-standalone-mode-all-alpha #33659

Merged
merged 1 commit into from
Oct 15, 2024
Merged

disable Evented PLEG for ci-kubernetes-node-e2e-containerd-standalone-mode-all-alpha #33659

merged 1 commit into from
Oct 15, 2024
+1 −1

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Oct 15, 2024

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 15, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Oct 15, 2024

/cc @haircommander
/assign @kannon92 @SergeyKanzhelev

@kannon92
Copy link
Contributor

Can we file a bug for EventedPleg breaking this before we turn it off?

Otherwise

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2024
@kannon92
Copy link
Contributor

kannon92 commented Oct 15, 2024 •
edited
Loading

/hold

Let’s at least document this problem. Please feel free to unhold once that is done.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2024
@kannon92
Copy link
Contributor

/hold cancel

I change my mind...

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 41f2d4c into kubernetes:master Oct 15, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@pacoxu: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml

In response to this:

similar to #33642

fixes kubernetes/kubernetes#127814

https://testgrid.k8s.io/sig-node-release-blocking#node-kubelet-containerd-standalone-mode-all-alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pacoxu pacoxu mentioned this pull request Oct 16, 2024
Open
@pacoxu
Copy link
Member Author

pacoxu commented Oct 16, 2024

/hold

Let’s at least document this problem. Please feel free to unhold once that is done.

I create an issue to track #33666.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92

@sjenning sjenning Awaiting requested review from sjenning

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@kannon92 kannon92

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"[sig-node] [Feature:StandaloneMode] when creating a static pod the pod should be running" test failing
4 participants
@pacoxu @kannon92 @k8s-ci-robot @SergeyKanzhelev