Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove vsphere janitor job #33246

Merged
merged 1 commit into from
Aug 6, 2024
Merged

remove vsphere janitor job #33246

merged 1 commit into from
Aug 6, 2024

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Aug 6, 2024 •
edited
Loading

there are no resources to clean up anymore as there are no more running jobs and the janitor has run multiple times since then (https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-provider-vsphere-janitor/1820938936952819712)

refer to #33226 #33129

@BenTheElder
remove vsphere janitor job
265c76d 
there are no resources to clean up anymore as there are no more running jobs and the janitor has run multiple times since then
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 6, 2024
@BenTheElder BenTheElder mentioned this pull request Aug 6, 2024
Closed
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1291c95 into kubernetes:master Aug 6, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-vsphere-main-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-vsphere/cluster-api-provider-vsphere-main-periodics.yaml

In response to this:

there are no resources to clean up anymore as there are no more running jobs and the janitor has run multiple times since then (https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-provider-vsphere-janitor/1820938936952819712)

refer to #33226 #33129

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ameukam
Copy link
Member

ameukam commented Aug 7, 2024

FYI @sbueringer @chrischdi @fabriziopandini

@BenTheElder BenTheElder deleted the vsphere-janitor-remove branch August 7, 2024 15:19
@BenTheElder BenTheElder mentioned this pull request Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@aojea aojea Awaiting requested review from aojea

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @ameukam @michelle192837