Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unmigrated scalability presubmits #33229

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

BenTheElder
Copy link
Member

Refer to #33226 and #33128

Will remove the legacy GCP janitor jobs in a follow-up, there's a couple other CI jobs remaining with legacy GCP references anyhow, and we want to be sure there are no recent runs since the last janitor run first.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot requested review from mborsz and mm4tt August 5, 2024 21:59
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2024
@BenTheElder
Copy link
Member Author

I'm also punting the docs/job-migration-todo.md & presubmit test updates to avoid rebase hell, will roll those up after the other PRs.

@ameukam
Copy link
Member

ameukam commented Aug 5, 2024

FYI @kubernetes/sig-scalability-leads

/lgtm
/hold

Remove the hold when ready.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@BenTheElder
Copy link
Member Author

/hold cancel

We have options to re-introduce these on community resources if desired, see #33128 (comment)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2024
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dims
Copy link
Member

dims commented Aug 5, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e92f11c into kubernetes:master Aug 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-scalability-presubmit-jobs.yaml using file config/jobs/kubernetes/sig-scalability/sig-scalability-presubmit-jobs.yaml

In response to this:

Refer to #33226 and #33128

Will remove the legacy GCP janitor jobs in a follow-up, there's a couple other CI jobs remaining with legacy GCP references anyhow, and we want to be sure there are no recent runs since the last janitor run first.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the scale-cleanup branch August 5, 2024 22:28
@BenTheElder
Copy link
Member Author

BenTheElder commented Aug 5, 2024

We actually have no recorded runs of these, so we should be good to remove the janitors after removing the other remaining jobs that reference external GCP resources #33231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants