Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip sig-cloud-provider-gcp labelled tests after in-tree cloud provider removal #33222

Merged

Conversation

Vyom-Yadav
Copy link
Member

Fixes https://testgrid.k8s.io/sig-release-1.31-informing#gce-cos-k8sbeta-serial failure.

In-tree cloud provider extensions were removed. kubernetes/kubernetes#124519
These tests haven't been fixed yet and should be skipped.

k/k master branch issue: kubernetes/kubernetes#124748

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 5, 2024
@Vyom-Yadav
Copy link
Member Author

/assign @dims @mehabhalodiya

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 5, 2024
@Vyom-Yadav
Copy link
Member Author

There were some other changes after generating the config again. I'm assuming those were manually patched, so I reverted those.

@aojea
Copy link
Member

aojea commented Aug 5, 2024

/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, Vyom-Yadav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 252143c into kubernetes:master Aug 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@Vyom-Yadav: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key generated.yaml using file config/jobs/kubernetes/generated/generated.yaml

In response to this:

Fixes https://testgrid.k8s.io/sig-release-1.31-informing#gce-cos-k8sbeta-serial failure.

In-tree cloud provider extensions were removed. kubernetes/kubernetes#124519
These tests haven't been fixed yet and should be skipped.

k/k master branch issue: kubernetes/kubernetes#124748

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -52,6 +52,8 @@ jobs:
sigOwners: [sig-cloud-provider-gcp]
releaseBlocking: true
ci-kubernetes-e2e-gce-cos-k8sbeta-serial:
args:
- --test_args=--ginkgo.focus=\[Serial\]|\[Disruptive\] --ginkgo.skip=\[Driver:.gcepd\]|\[Flaky\]|\[Feature:.+\]\[sig-cloud-provider-gcp\] --minStartupPods=8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff --git a/releng/test_config.yaml b/releng/test_config.yaml
index 168651fb36..39ac27e557 100644
--- a/releng/test_config.yaml
+++ b/releng/test_config.yaml
@@ -53,7 +53,7 @@ jobs:
     releaseBlocking: true
   ci-kubernetes-e2e-gce-cos-k8sbeta-serial:
     args:
-    - --test_args=--ginkgo.focus=\[Serial\]|\[Disruptive\] --ginkgo.skip=\[Driver:.gcepd\]|\[Flaky\]|\[Feature:.+\]\[sig-cloud-provider-gcp\] --minStartupPods=8  
+    - --test_args=--ginkgo.focus=\[Serial\]|\[Disruptive\] --ginkgo.skip=\[Driver:.gcepd\]|\[Flaky\]|\[Feature:.+\]|\[sig-cloud-provider-gcp\] --minStartupPods=8
     interval: 1h
     sigOwners: [sig-cloud-provider-gcp]
     releaseInforming: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants