Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secrets to job migration todo #33127

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Add secrets to job migration todo #33127

merged 2 commits into from
Jul 26, 2024

Conversation

BenTheElder
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2024
@k8s-ci-robot k8s-ci-robot requested review from aojea and cjwagner July 26, 2024 21:43
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 26, 2024
@BenTheElder
Copy link
Member Author

rendered: https://github.com/kubernetes/test-infra/blob/c07743937db229f188a21c166d1d5a82523aea82/docs/job-migration-todo.md

@BenTheElder BenTheElder changed the title WIP: add secrets to job migration todo Add secrets to job migration todo Jul 26, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,michelle192837]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder BenTheElder mentioned this pull request Jul 26, 2024
Closed
54 tasks
@k8s-ci-robot k8s-ci-robot merged commit 930a66f into kubernetes:master Jul 26, 2024
5 checks passed
@BenTheElder BenTheElder deleted the todo-secrets branch July 26, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@aojea aojea Awaiting requested review from aojea

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @michelle192837