Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ImageVolume tests for pull-kubernetes-node-e2e-containerd-alpha-features #33095

Conversation

saschagrunert
Copy link
Member

containerd does not seem to have support for image volumes yet, so we can skip the tests in the alpha node e2e test suite.

Refers to kubernetes/kubernetes#126220

…pha-features`

containerd does not seem to have support for image volumes yet, so we
can skip the tests in the alpha node e2e test suite.

Refers to kubernetes/kubernetes#126220

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 24, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 24, 2024
@saschagrunert
Copy link
Member Author

/hold

Let's see if we need this in kubernetes/kubernetes#126334

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
@saschagrunert
Copy link
Member Author

@saschagrunert
Copy link
Member Author

Yes, we need this: https://prow.k8s.io/log?container=test&id=1816108644320677888&job=pull-kubernetes-node-e2e-containerd-alpha-features

Summarizing 4 Failures:
  [FAIL] [sig-node] ImageVolume [NodeFeature:ImageVolume] [It] should succeed with pod and pull policy of Always [sig-node, NodeFeature:ImageVolume]
  k8s.io/kubernetes/test/e2e/framework/pod/exec_util.go:112
  [FAIL] [sig-node] ResourceMetricsAPI [NodeFeature:ResourceMetrics] when querying /resource/metrics [It] should report resource usage through the resource metrics api [sig-node, NodeFeature:ResourceMetrics]
  k8s.io/kubernetes/test/e2e_node/resource_metrics_test.go:120
  [FAIL] [sig-node] ImageVolume [NodeFeature:ImageVolume] [It] should fail if image volume is not existing [sig-node, NodeFeature:ImageVolume]
  k8s.io/kubernetes/test/e2e_node/image_volume.go:140
  [FAIL] [sig-node] ImageVolume [NodeFeature:ImageVolume] [It] should succeed with pod and multiple volumes [sig-node, NodeFeature:ImageVolume]
  k8s.io/kubernetes/test/e2e/framework/pod/exec_util.go:112

Ran 138 of 658 Specs in 605.973 seconds
FAIL! -- 134 Passed | 4 Failed | 0 Pending | 520 Skipped

@saschagrunert
Copy link
Member Author

/unhold

PTAL @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit efc3035 into kubernetes:master Jul 24, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

containerd does not seem to have support for image volumes yet, so we can skip the tests in the alpha node e2e test suite.

Refers to kubernetes/kubernetes#126220

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@saschagrunert saschagrunert deleted the image-volume-pull-kubernetes-node-e2e-containerd-alpha-features branch July 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants