-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable ImageVolume tests for pull-kubernetes-node-e2e-containerd-alpha-features
#33095
Disable ImageVolume tests for pull-kubernetes-node-e2e-containerd-alpha-features
#33095
Conversation
…pha-features` containerd does not seem to have support for image volumes yet, so we can skip the tests in the alpha node e2e test suite. Refers to kubernetes/kubernetes#126220 Signed-off-by: Sascha Grunert <[email protected]>
/hold Let's see if we need this in kubernetes/kubernetes#126334 |
The test seems to fail for the last runs: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-node-e2e-containerd-alpha-features |
Yes, we need this: https://prow.k8s.io/log?container=test&id=1816108644320677888&job=pull-kubernetes-node-e2e-containerd-alpha-features
|
/unhold PTAL @kubernetes/sig-node-pr-reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: endocrimes, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@saschagrunert: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
containerd does not seem to have support for image volumes yet, so we can skip the tests in the alpha node e2e test suite.
Refers to kubernetes/kubernetes#126220