-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Azure cluster-autoscaler e2e #32832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- org: nojnhuh # change to kubernetes-sigs when fully baked | ||
repo: cluster-api-provider-azure | ||
base_ref: cluster-autoscaler-e2e # change to latest release branch when fully baked | ||
base_ref: cas # change to latest release branch when fully baked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to update this to the upstream main branch of CAPZ once kubernetes-sigs/cluster-api-provider-azure#4946 is merged.
@nojnhuh: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR updates the cluster-autoscaler e2e tests for the Azure provider to invoke the boilerplate I've set up in cluster-autoscaler in kubernetes/autoscaler#6969.
/assign @jackfrancis @willie-yao