Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure cluster-autoscaler e2e #32832

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jun 25, 2024

This PR updates the cluster-autoscaler e2e tests for the Azure provider to invoke the boilerplate I've set up in cluster-autoscaler in kubernetes/autoscaler#6969.

/assign @jackfrancis @willie-yao

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +21 to +23
- org: nojnhuh # change to kubernetes-sigs when fully baked
repo: cluster-api-provider-azure
base_ref: cluster-autoscaler-e2e # change to latest release branch when fully baked
base_ref: cas # change to latest release branch when fully baked
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to update this to the upstream main branch of CAPZ once kubernetes-sigs/cluster-api-provider-azure#4946 is merged.

@k8s-ci-robot k8s-ci-robot merged commit b471b70 into kubernetes:master Jun 25, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-autoscaler-azure-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/azure/cluster-autoscaler-azure-presubmits.yaml

In response to this:

This PR updates the cluster-autoscaler e2e tests for the Azure provider to invoke the boilerplate I've set up in cluster-autoscaler in kubernetes/autoscaler#6969.

/assign @jackfrancis @willie-yao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants