Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "disable sctp on network policy tests" #32396

Merged
merged 1 commit into from
Apr 7, 2024

Conversation

aojea
Copy link
Member

@aojea aojea commented Apr 7, 2024

This reverts commit 57cff76.

After a long week of troubleshooting the current job everything has been sorted out so we should back to the previous state

Network policy test heavily use exec and Containerd v1.7.14 bug on exec was blocking the job #32394

SCTP seems to have some bug on the kernel when using nfqueue that can be solved by setting a specific flag on the nfqueue config aojea/kube-netpol#7

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 7, 2024
@k8s-ci-robot k8s-ci-robot requested review from bowei and cadmuxe April 7, 2024 11:45
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Just in case there's any last minute thing, please feel free to remove hold whenever!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member Author

aojea commented Apr 7, 2024

/hold cancel

Thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit d3e7bc3 into kubernetes:master Apr 7, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@aojea: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml

In response to this:

This reverts commit 57cff76.

After a long week of troubleshooting the current job everything has been sorted out so we should back to the previous state

Network policy test heavily use exec and Containerd v1.7.14 bug on exec was blocking the job #32394

SCTP seems to have some bug on the kernel when using nfqueue that can be solved by setting a specific flag on the nfqueue config aojea/kube-netpol#7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants