Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove manager jobs from our general serial jobs #32271

Merged
merged 1 commit into from
Apr 8, 2024
Merged

remove manager jobs from our general serial jobs #32271

merged 1 commit into from
Apr 8, 2024

Conversation

kannon92
Copy link
Contributor

(Cpu, Topology, Memory)Manager jobs are already covered as separate jobs in periodics.

We find that alot of these tests are skipped in the general one and those that are not take quite a long time.

I was thinking we can filter out these tests so we can avoid having really long serial tests.

Removed from containerd/crio in both periodics and presubmits.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2024
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 15, 2024
@kannon92 kannon92 mentioned this pull request Mar 15, 2024
Closed
6 tasks
@bart0sh
Copy link
Contributor

bart0sh commented Mar 17, 2024

/hold
I'd propose to wait until kubernetes/kubernetes#123589 is fixed.
Last run of the Serial jobs with almost everything enabled took only around 2h.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2024
@bart0sh
Copy link
Contributor

bart0sh commented Mar 20, 2024

(Cpu, Topology, Memory)Manager jobs are already covered as separate jobs in periodics.

Can we also cover them by pull- tests? For now the only way to run them for PRs is to trigger pull serial jobs as far as I understand.

/cc @SergeyKanzhelev

@swatisehgal
Copy link
Contributor

/cc

swatisehgal
swatisehgal approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@swatisehgal
Copy link
Contributor

/assign @SergeyKanzhelev
for approval

@kannon92
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, SergeyKanzhelev, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
SergeyKanzhelev
SergeyKanzhelev reviewed Apr 5, 2024
View reviewed changes
config/jobs/kubernetes/sig-node/node-kubelet.yaml
@@ -81,7 +81,7 @@ periodics:
- '--node-test-args=--container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{\"name\": \"containerd.log\", \"journalctl\": [\"-u\", \"containerd*\"]}"'
- --node-tests=true
- --provider=gce
- --test_args=--nodes=1 --timeout=4h --focus="\[Serial\]" --skip="\[Flaky\]|\[Benchmark\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[NodeFeature:Eviction\]"
- --test_args=--nodes=1 --timeout=4h --focus="\[Serial\]" --skip="\[Flaky\]|\[Benchmark\]|\[NodeSpecialFeature:.+\]|\[NodeSpecialFeature\]|\[NodeAlphaFeature:.+\]|\[NodeAlphaFeature\]|\[NodeFeature:Eviction\]\[Feature:CPUManager\]|\[Feature:MemoryManager\]|\[Feature:TopologyManager\]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a comment explaining why those sckipped so we will have it directly in code. It may establish a good practice for future so we know why things are skipped - it was not clear in past and hard to dig why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the comment to all jobs.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 5, 2024
@kannon92 kannon92 force-pushed the filter-out-manager-jobs branch from b0d8150 to 8bc23e9 Compare April 8, 2024 13:20
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@kannon92 kannon92 force-pushed the filter-out-manager-jobs branch from 8bc23e9 to 5c246f1 Compare April 8, 2024 13:21
@kannon92 kannon92 requested a review from SergeyKanzhelev April 8, 2024 13:22
@kannon92 kannon92 closed this Apr 8, 2024
@kannon92 kannon92 reopened this Apr 8, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Apr 8, 2024

rebase label seems stuck.

@bart0sh
Copy link
Contributor

bart0sh commented Apr 8, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2d45128 into kubernetes:master Apr 8, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@kannon92: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

(Cpu, Topology, Memory)Manager jobs are already covered as separate jobs in periodics.

We find that alot of these tests are skipped in the general one and those that are not take quite a long time.

I was thinking we can filter out these tests so we can avoid having really long serial tests.

Removed from containerd/crio in both periodics and presubmits.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kannon92 @bart0sh @swatisehgal @k8s-ci-robot @SergeyKanzhelev