Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

csi: move alpha and canary to community cluster #30968

Closed
wants to merge 1 commit into from
Closed

csi: move alpha and canary to community cluster #30968

wants to merge 1 commit into from

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Oct 6, 2023

Related to:

Move alpha and canary prowjobs to GKE cluster k8s-infra-prow-build

@ameukam
csi: move alpha and canary to community cluster
687f20c 
Related to:
 - kubernetes#30277

Move alpha and canary prowjobs to GKE cluster k8s-infra-prow-build

Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 6, 2023
@ameukam
Copy link
Member Author

ameukam commented Oct 6, 2023

cc @rjsadow

@rjsadow
Copy link
Contributor

rjsadow commented Oct 6, 2023

/lgtm
/hold
/cc @pohly

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2023
@rjsadow
Copy link
Contributor

rjsadow commented Oct 6, 2023

@ameukam can we use https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-csi/gen-jobs.sh#L139 instead of setting the cluster directly like we do with many of the other jobs? It looks like I might have missed this job previously.

@ameukam
Copy link
Member Author

ameukam commented Jan 18, 2024

@rjsadow Can you take over this ? 🙏🏾

@rjsadow rjsadow mentioned this pull request Jan 18, 2024
Merged
@ameukam
Copy link
Member Author

ameukam commented Jan 25, 2024

/close
In favor of:

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

/close
In favor of:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly Awaiting requested review from pohly

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@rjsadow rjsadow

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @rjsadow