Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CAPZ presubmit for ipv6 ci conformance #30933

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Add CAPZ presubmit for ipv6 ci conformance #30933

merged 1 commit into from
Oct 3, 2023

Conversation

CecileRobertMichon
Copy link
Member

Add optional job to test kubernetes-sigs/cluster-api-provider-azure#4086, will eventually convert into a periodic job to test every branch of k8s

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added area/jobs approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 3, 2023
CecileRobertMichon
CecileRobertMichon commented Oct 3, 2023
View reviewed changes
Copy link
Member Author

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @mboersma @willie-yao @nawazkh

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
CecileRobertMichon
CecileRobertMichon commented Oct 3, 2023
View reviewed changes
...s/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml
env:
- name: E2E_ARGS
value: "-kubetest.use-ci-artifacts"
- name: IP_FAMILY
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the main difference between this job and the one above (pull-cluster-api-provider-azure-conformance-with-ci-artifacts)

CecileRobertMichon
CecileRobertMichon commented Oct 3, 2023
View reviewed changes
...s/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml Outdated
always_run: false
optional: true
decorate: true
run_if_changed: 'test\/e2e|templates\/test|scripts\/ci-conformance.sh|Makefile'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

I need to remove this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2023
@nawazkh
Copy link
Contributor

nawazkh commented Oct 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2023
willie-yao
willie-yao reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question on my end: Does this test need this line?

run_if_changed: 'test\/e2e|templates\/test|scripts\/ci-conformance.sh|Makefile'

Since the test above has it and it is also a conformance test

@CecileRobertMichon
Copy link
Member Author

@willie-yao good question, I removed that line so it wouldn't get triggered on every PR that changes those files, since the test won't fully work until kubernetes-sigs/cluster-api-provider-azure#4086 merges

@willie-yao
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 05d895d into kubernetes:master Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-azure-presubmits-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-main.yaml

In response to this:

Add optional job to test kubernetes-sigs/cluster-api-provider-azure#4086, will eventually convert into a periodic job to test every branch of k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis mentioned this pull request Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao left review comments

@marosset marosset Awaiting requested review from marosset

Assignees

@mboersma mboersma

@nawazkh nawazkh

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CecileRobertMichon @k8s-ci-robot @nawazkh @willie-yao @mboersma