Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crio jobs should use community cluster #30793

Merged
merged 2 commits into from
Sep 25, 2023
Merged

crio jobs should use community cluster #30793

merged 2 commits into from
Sep 25, 2023

Conversation

kannon92
Copy link
Contributor

@kannon92 kannon92 commented Sep 21, 2023 •
edited
Loading

Add community cluster label to all crio periodic jobs.

Following #29722

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 21, 2023
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 21, 2023
@kannon92 kannon92 mentioned this pull request Sep 21, 2023
Merged
@pacoxu
Copy link
Member

pacoxu commented Sep 22, 2023

As the CI failure says, you have to add CPU memory limit/requirements for the jobs after using the community cluster.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2023
@kannon92
Copy link
Contributor Author

As the CI failure says, you have to add CPU memory limit/requirements for the jobs after using the community cluster.

Updated all the jobs to have memory limit/requirements

@pacoxu
Copy link
Member

pacoxu commented Sep 22, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Sep 25, 2023

/assign @mrunalp @SergeyKanzhelev

@haircommander
Copy link
Contributor

/approve

@kannon92 kannon92 force-pushed the crio-community-cluster branch from edfa0bb to 9ba477f Compare September 25, 2023 16:08
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, kannon92, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@k8s-ci-robot k8s-ci-robot merged commit f1a68e6 into kubernetes:master Sep 25, 2023
@k8s-ci-robot
Copy link
Contributor

@kannon92: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key crio.yaml using file config/jobs/kubernetes/sig-node/crio.yaml

In response to this:

Add community cluster label to all crio periodic jobs.

Following #29722

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@pacoxu pacoxu Awaiting requested review from pacoxu

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@mrunalp mrunalp

@pacoxu pacoxu

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kannon92 @pacoxu @bart0sh @haircommander @k8s-ci-robot @SergeyKanzhelev @mrunalp