images/krte/Dockerfile: fulfill GO_VERSION when unspecified #30743
Conversation
This helps locally experimenting the image with `docker build`. Prior to this commit, `docker build` was failing unless `--build-arg GO_VERSION=...` was explicitly specified. Signed-off-by: Akihiro Suda <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/images
sig/testing
|
/assign @liggitt @BenTheElder |
There was a problem hiding this comment.
The flip side is this means that it's easier to miss failure to assign it in a build and so far it's expected to always be tightly controlled to match each k8s release.
However, we automatically obtain go in kind and kubernetes anyhow so having the right version pre-installed is just an optimization for one of those repos (or both if they currently match), so I guess this is safe. (We didn't until recently in Kubernetes, not sure which release)
You're docker building this directly without the build args?
Yes. |
|
ping @aojea @BenTheElder |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
/remove-lifecycle rotten |
k8s-ci-robot
removed
the
lifecycle/rotten
There was a problem hiding this comment.
I kinda generally don't want to the build to succeed with missing inputs to avoid masking CI misconfiguration around the build process which is not expected to just be a plain docker build but I guess this particular case is OK, at least kind and k/k will automatically control the go version anyhow.
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AkihiroSuda, BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This helps locally experimenting the image with
docker build.Prior to this commit,
docker buildwas failing unless--build-arg GO_VERSION=...was explicitly specified.