-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert capi-vsphere
integration jobs to GKE cluster
#30501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Can we run these jobs on the k8s-infra-prow-build cluster? It should behave the same way as the default(google owned GKE cluster) cluster. |
Will they? @chrischdi can you help me understand the github rate limit issue a bit more? Is there a unique secret or some other way of obtaining a token that CAPI currently has implemented? |
Yes I explained on Slack why rate limiting is more frequent in EKS Cluster than in the GKE Clusters. It is to do with the limited set of IPs available for egress traffic. On AWS we are using NAT Gateways but on GCP, every GKE node has it is own IP address so there is a larger pool of egress addresses available. With regards to getting a token:
|
Signed-off-by: Ricky Sadowski <[email protected]>
Thank you for that explanation @upodroid, I've updated the PR to move the jobs to the eks community cluster |
Thank you! Will follow-up on the token /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/lgtm |
@rjsadow: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR sends the integration jobs to running on the community GKE cluster due to github rate limit issues.
/cc @chrischdi @sbueringer @killianmuldoon