Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node e2e version printer for docker validation test. #304

Merged

Conversation

Random-Liu
Copy link
Member

The log printed by node e2e docker validation test is like this:

++ DOCKER_VERSION=1.12.0-rc4
++ GCI_CLOUD_INIT=test/e2e_node/jenkins/gci-init.yaml
++ GCE_HOSTS=
++ GCE_IMAGES=gci-test-54-8618-0-0
++ GCE_IMAGE_PROJECT=container-vm-image-staging
++ GCE_ZONE=us-central1-f
++ GCE_PROJECT=google.com:noogler-kubernetes
++ GCE_INSTANCE_METADATA='user-data<test/e2e_node/jenkins/gci-init.yaml,gci-docker-version=1.12.0-rc4'
++ CLEANUP=true
++ GINKGO_FLAGS=--skip=FLAKY
++ SETUP_NODE=true

This PR added a version printer to print DOCKER_VERSION and GCI_IMAGE.

@wonderfly Could you take a look? Thanks a lot! :)

publishers:
- groovy-postbuild:
script: |
def imageMatcher = manager.getLogMatcher("GCE_IMAGE=(.*)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your log shows GCE_IMAGES=gci-test-54-8618-0-0 - notice the S.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't post the first few lines:

++ GCI_IMAGE_PROJECT=container-vm-image-staging
++ GCI_IMAGE_FAMILY=gci-canary-test
+++ gcloud compute images describe-from-family gci-canary-test --project=container-vm-image-staging '--format=value(name)'
++ GCI_IMAGE=gci-test-54-8618-0-0 <-------------- Here
+++ curl -fsSL --retry 3 https://api.github.com/repos/docker/docker/releases
+++ tac
+++ grep -m 1 '"tag_name"\:'
+++ grep -Eo '[0-9\.rc-]+'
+++ tac
++ DOCKER_VERSION=1.12.0-rc4
++ GCI_CLOUD_INIT=test/e2e_node/jenkins/gci-init.yaml
++ GCE_HOSTS=
++ GCE_IMAGES=gci-test-54-8618-0-0
++ GCE_IMAGE_PROJECT=container-vm-image-staging
++ GCE_ZONE=us-central1-f
++ GCE_PROJECT=google.com:noogler-kubernetes
++ GCE_INSTANCE_METADATA='user-data<test/e2e_node/jenkins/gci-init.yaml,gci-docker-version=1.12.0-rc4'
++ CLEANUP=true
++ GINKGO_FLAGS=--skip=FLAKY
++ SETUP_NODE=true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it should be GCI_IMAGE=, as opposed to GCE_IMAGE=, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, my bad. Good catch!

@Random-Liu Random-Liu force-pushed the add-node-e2e-version-printer branch from 42b138f to 28beeae Compare July 22, 2016 17:29
@wonderfly wonderfly added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2016
@Random-Liu Random-Liu merged commit 7f19652 into kubernetes:master Jul 23, 2016
@Random-Liu Random-Liu deleted the add-node-e2e-version-printer branch July 23, 2016 00:29
mborsz pushed a commit to mborsz/test-infra that referenced this pull request Dec 14, 2018
ClusterLoader - Moving errors to pkg/errors
ostromart pushed a commit to ostromart/test-infra that referenced this pull request Jul 26, 2019
Automatic merge from submit-queue

prow: correct periodics config

Fixes istio/test-infra#303

```release-note
NONE
```
grantr pushed a commit to grantr/test-infra that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jenkins lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants