Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate cluster-api 1.3 jobs to the community cluster #30279

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Aug 2, 2023

This PR moves the cluster-api 1.3 jobs from the GCP cluster to the community owned EKS cluster.

ref: #29722
ref: kubernetes-sigs/cluster-api#8689

/cc @fabriziopandini @sbueringer @killianmuldoon

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 2, 2023
memory: 9Gi
limits:
cpu: 7300m
memory: 9Gi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@killianmuldoon Do you remember the Slack discussion? I think they were saying we don't have to be too strict with memory. Just want to avoid having to debug flakes becuase of OOM kills
(the Prow nodes are relatively memory heavy)

Copy link
Contributor

@killianmuldoon killianmuldoon Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the discussion in question - https://kubernetes.slack.com/archives/C7J9RP96G/p1685551306721239

I think we can go to 32 Gi here without causing issus. The instances apparently have 8Gi / core so 4Gi / core is still below utilization.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for looking it up. Sound reasonable for me to then use 32 Gi for all e2e / conformance / upgrade job

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated all e2e / conformance / upgrade jobs to 32Gi

@sbueringer
Copy link
Member

sbueringer commented Aug 4, 2023

Thx!

If I see correctly we now have the following config:

  • e2e test jobs: 7300m cpu & 32 Gi memory
  • everything else: 7300m cpu & 9 Gi memory

Let's use this as a starting point and see how much we actually need.

We definitely shouldn't tune to close to our real usage though as it's probably not worth debugging the flakes

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6f33409 into kubernetes:master Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

@rjsadow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-periodics-release-1-3-upgrades.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-3-upgrades.yaml
  • key cluster-api-periodics-release-1-3.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-periodics-release-1-3.yaml
  • key cluster-api-presubmits-release-1-3.yaml using file config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-3.yaml

In response to this:

This PR moves the cluster-api 1.3 jobs from the GCP cluster to the community owned EKS cluster.

ref: #29722
ref: kubernetes-sigs/cluster-api#8689

/cc @fabriziopandini @sbueringer @killianmuldoon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants