-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate cluster-api 1.3
jobs to the community cluster
#30279
Conversation
config/jobs/kubernetes-sigs/cluster-api/cluster-api-presubmits-release-1-3.yaml
Show resolved
Hide resolved
memory: 9Gi | ||
limits: | ||
cpu: 7300m | ||
memory: 9Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@killianmuldoon Do you remember the Slack discussion? I think they were saying we don't have to be too strict with memory. Just want to avoid having to debug flakes becuase of OOM kills
(the Prow nodes are relatively memory heavy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the discussion in question - https://kubernetes.slack.com/archives/C7J9RP96G/p1685551306721239
I think we can go to 32 Gi here without causing issus. The instances apparently have 8Gi / core so 4Gi / core is still below utilization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for looking it up. Sound reasonable for me to then use 32 Gi for all e2e / conformance / upgrade job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated all e2e / conformance / upgrade jobs to 32Gi
Signed-off-by: rjsadow <[email protected]>
Thx! If I see correctly we now have the following config:
Let's use this as a starting point and see how much we actually need. We definitely shouldn't tune to close to our real usage though as it's probably not worth debugging the flakes /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rjsadow: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR moves the cluster-api 1.3 jobs from the GCP cluster to the community owned EKS cluster.
ref: #29722
ref: kubernetes-sigs/cluster-api#8689
/cc @fabriziopandini @sbueringer @killianmuldoon