Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding guidance for test jobs in Sig Node #29969

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Adding guidance for test jobs in Sig Node #29969

merged 1 commit into from
Aug 2, 2023

Conversation

ndixita
Copy link
Contributor

@ndixita ndixita commented Jun 29, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 29, 2023
@upodroid upodroid mentioned this pull request Jun 30, 2023
Closed
upodroid
upodroid requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on a prowjob generator in #29944 and will configure the matrix based on what we merge in this PR.

The generator is almost ready, I need to fix a few things in kubetest2

config/jobs/kubernetes/sig-node/README.md
## Variables


<table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Can you add the following rows:

  • architecture: amd64 & arm64
  • clouds: gce & ec2

config/jobs/kubernetes/sig-node/README.md Show resolved Hide resolved
config/jobs/kubernetes/sig-node/README.md Outdated Show resolved Hide resolved
config/jobs/kubernetes/sig-node/README.md

#### 1. **sig-node-default (i.e. rename sig-node-release-blocking)**

<table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need a dashboard for:

  • for each architecture
  • for each cloud

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will discuss this in tomorrow's sig CI meeting and accommodate this

@SergeyKanzhelev
Copy link
Member

/assign

@ndixita
Copy link
Contributor Author

ndixita commented Aug 1, 2023

/assign @dims

@dims
Copy link
Member

dims commented Aug 1, 2023

/approve

this is a great start. thanks @ndixita.

yes, +1 to automation to populate these @upodroid

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2023
@SergeyKanzhelev
Copy link
Member

/lgtm
/approve

Let's merge and iterate

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ndixita, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7094b8 into kubernetes:master Aug 2, 2023
@upodroid
Copy link
Member

upodroid commented Aug 2, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid requested changes

@bart0sh bart0sh Awaiting requested review from bart0sh

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees

@dims dims

@SergeyKanzhelev SergeyKanzhelev

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ndixita @SergeyKanzhelev @dims @k8s-ci-robot @upodroid