Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cluster-api-provider-cloudstack jobs to eks-prow-build-cluster #29877

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Jun 20, 2023

See #29722

This PR does not migrate the smoke test job as it creates clusters using an external CloudStack instance. The job is a trigger for an external system so its possible it'll work but we can deal with it separately.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2023
@k8s-ci-robot k8s-ci-robot requested review from dims and wojtek-t June 20, 2023 14:26
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisdoherty4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 20, 2023
@chrisdoherty4
Copy link
Member Author

/assign @rohityadavcloud @g-gaston @weizhouapache

@rjsadow
Copy link
Contributor

rjsadow commented Jun 20, 2023

Hi @chrisdoherty4, the PR title says these are moving to eks-prow-build-cluster but it looks like k8s-infra-prow-build is defined as the clusters. Did you mean to make those eks?

@weizhouapache
Copy link
Contributor

@chrisdoherty4
code looks good to me.
do we need to mgirate capi-provider-cloudstack-presubmit-e2e-smoke-test as well ?

@chrisdoherty4
Copy link
Member Author

chrisdoherty4 commented Jun 20, 2023

Hi @chrisdoherty4, the PR title says these are moving to eks-prow-build-cluster but it looks like k8s-infra-prow-build is defined as the clusters. Did you mean to make those eks?

@rjsadow Thank you, it should've been eks-prow-build-cluster. Updated.

@chrisdoherty4 code looks good to me. do we need to mgirate capi-provider-cloudstack-presubmit-e2e-smoke-test as well ?

@weizhouapache As noted in the OP, I refrained from touching that job as it integrates with an external system and the general advice is to avoid migrating those right now.

@weizhouapache
Copy link
Contributor

@weizhouapache As noted in the OP, I refrained from touching that job as it integrates with an external system and the general advice is to avoid migrating those right now.

@chrisdoherty4
the PR kubernetes-sigs/cluster-api-provider-cloudstack#259 describes what smoke test does, which may not require extra configurations or external systems. It can be migrated in another PR.

@weizhouapache
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3944e7c into kubernetes:master Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

@chrisdoherty4: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key capi-provider-cloudstack-presumbit.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-cloudstack/capi-provider-cloudstack-presumbit.yaml

In response to this:

See #29722

This PR does not migrate the smoke test job as it creates clusters using an external CloudStack instance. The job is a trigger for an external system so its possible it'll work but we can deal with it separately.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrisdoherty4
Copy link
Member Author

chrisdoherty4 commented Jun 20, 2023

@weizhouapache As noted in the OP, I refrained from touching that job as it integrates with an external system and the general advice is to avoid migrating those right now.

@chrisdoherty4 the PR kubernetes-sigs/cluster-api-provider-cloudstack#259 describes what smoke test does, which may not require extra configurations or external systems. It can be migrated in another PR.

Thanks @weizhouapache, I'll raise another PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants